starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Site: Removing timezone fails via api because time_zone does not allow nulls #7191

New Issue
Closed
opened 2025-12-29 20:20:19 +01:00 by adam · 2 comments
adam commented 2025-12-29 20:20:19 +01:00
Owner
Copy Link

Originally created by @amhn on GitHub (Nov 1, 2022).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.3.6 & master

Python version

3.10

Steps to Reproduce

  1. Create site with time_zone, e.g. Europe/Berline
  2. Send {"time_zone": null} to /api/dcim/site// method PATCH

Expected Behavior

Time zone is unset.

Observed Behavior

An error is returned:

{"time_zone":["This field may not be null."]}
Originally created by @amhn on GitHub (Nov 1, 2022). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.3.6 & master ### Python version 3.10 ### Steps to Reproduce 1. Create site with time_zone, e.g. Europe/Berline 2. Send `{"time_zone": null}` to /api/dcim/site/<id>/ method PATCH ### Expected Behavior Time zone is unset. ### Observed Behavior An error is returned: ``` {"time_zone":["This field may not be null."]} ```
adam added the type: bugstatus: accepted labels 2025-12-29 20:20:19 +01:00
adam closed this issue 2025-12-29 20:20:19 +01:00
adam commented 2025-12-29 20:20:20 +01:00
Author
Owner
Copy Link

@amhn commented on GitHub (Nov 1, 2022):

Fixed with:

diff --git a/netbox/dcim/api/serializers.py b/netbox/dcim/api/serializers.py
index 897ee4ca3..cb1edfe1f 100644
--- a/netbox/dcim/api/serializers.py
+++ b/netbox/dcim/api/serializers.py
@@ -130,7 +130,7 @@ class SiteSerializer(NetBoxModelSerializer):
     region = NestedRegionSerializer(required=False, allow_null=True)
     group = NestedSiteGroupSerializer(required=False, allow_null=True)
     tenant = NestedTenantSerializer(required=False, allow_null=True)
-    time_zone = TimeZoneSerializerField(required=False)
+    time_zone = TimeZoneSerializerField(required=False, allow_null=True)
     asns = SerializedPKRelatedField(
         queryset=ASN.objects.all(),
         serializer=NestedASNSerializer,

See also #10791

@amhn commented on GitHub (Nov 1, 2022): Fixed with: ``` diff --git a/netbox/dcim/api/serializers.py b/netbox/dcim/api/serializers.py index 897ee4ca3..cb1edfe1f 100644 --- a/netbox/dcim/api/serializers.py +++ b/netbox/dcim/api/serializers.py @@ -130,7 +130,7 @@ class SiteSerializer(NetBoxModelSerializer): region = NestedRegionSerializer(required=False, allow_null=True) group = NestedSiteGroupSerializer(required=False, allow_null=True) tenant = NestedTenantSerializer(required=False, allow_null=True) - time_zone = TimeZoneSerializerField(required=False) + time_zone = TimeZoneSerializerField(required=False, allow_null=True) asns = SerializedPKRelatedField( queryset=ASN.objects.all(), serializer=NestedASNSerializer, ``` See also #10791
adam commented 2025-12-29 20:20:20 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Nov 1, 2022):

Thanks!

@jeremystretch commented on GitHub (Nov 1, 2022): Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7191
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?