starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Pass the current request when initializing a filterset within a UI view #7190

New Issue
Closed
opened 2025-12-29 20:20:19 +01:00 by adam · 0 comments
adam commented 2025-12-29 20:20:19 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Nov 2, 2022).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Currently, NetBox initializes django-filter FilterSets passing only the required data and queryset parameters, e.g.

if self.filterset:
    self.queryset = self.filterset(request.GET, self.queryset).qs

We can extend this to also pass the current request, which gets saved on the FilterSet instance:

if self.filterset:
    self.queryset = self.filterset(request.GET, self.queryset, request=request).qs

This should be applied to all occurrences of FitlerSet instantiation. (This already occurs for API views.)

Justification

Passing the current request to the FilterSet allows filters to reference additional context, such as the user making the request.

Originally created by @jeremystretch on GitHub (Nov 2, 2022). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Currently, NetBox initializes [django-filter]() FilterSets passing only the required data and queryset parameters, e.g. ```python if self.filterset: self.queryset = self.filterset(request.GET, self.queryset).qs ``` We can extend this to also pass the current request, which gets saved on the FilterSet instance: ```python if self.filterset: self.queryset = self.filterset(request.GET, self.queryset, request=request).qs ``` This should be applied to all occurrences of FitlerSet instantiation. (This already occurs for API views.) ### Justification Passing the current request to the FilterSet allows filters to reference additional context, such as the user making the request.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 20:20:19 +01:00
adam closed this issue 2025-12-29 20:20:19 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7190
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?