starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Add buttons to edit cables #7034

New Issue
Closed
opened 2025-12-29 19:48:08 +01:00 by adam · 10 comments
adam commented 2025-12-29 19:48:08 +01:00
Owner
Copy Link

Originally created by @dreng on GitHub (Sep 27, 2022).

Originally assigned to: @dreng on GitHub.

NetBox version

v3.3.4

Feature type

Change to existing functionality

Proposed functionality

The device view provides tabs for interfaces, power ports etc. On every line we have a button to connect a cable or, if a cable is connected already, a button to disconnect the cable.

I've got a PR ready that adds a button to all kinds of connection overviews (console ports, power ports, front ports, interfaces etc.). It looks like this:

grafik

Use case

What I miss here is a button to go directly to the edit page of the cable including a redirect to the page we came from. Best thing you can do at the moment is to click the link in the "Cable" column (if not hidden), edit the cable and go back to the connections overview manually. This approach is kinda cumbersome.

Database changes

None

External dependencies

None

Originally created by @dreng on GitHub (Sep 27, 2022). Originally assigned to: @dreng on GitHub. ### NetBox version v3.3.4 ### Feature type Change to existing functionality ### Proposed functionality The device view provides tabs for interfaces, power ports etc. On every line we have a button to connect a cable or, if a cable is connected already, a button to disconnect the cable. I've got a PR ready that adds a button to all kinds of connection overviews (console ports, power ports, front ports, interfaces etc.). It looks like this: ![grafik](https://user-images.githubusercontent.com/20901110/192557227-fac9f468-5338-4ef4-8da3-f180e5e3932d.png) ### Use case What I miss here is a button to go directly to the edit page of the cable including a redirect to the page we came from. Best thing you can do at the moment is to click the link in the "Cable" column (if not hidden), edit the cable and go back to the connections overview manually. This approach is kinda cumbersome. ### Database changes None ### External dependencies None
adam added the status: acceptedtype: feature labels 2025-12-29 19:48:08 +01:00
adam closed this issue 2025-12-29 19:48:08 +01:00
adam commented 2025-12-29 19:48:09 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 3, 2022):

There are quite a few buttons there as it is. What about merging several of the cable-relevant buttons under a dropdown (similar to the add/edit/changelog actions)? IMO it would make sense to list the trace cable, edit cable (new), and delete cable actions under a single button. There's also the toggle button to change the cable status, but that one probably needs to stay separate as it's a Javascript function.

@jeremystretch commented on GitHub (Oct 3, 2022): There are quite a few buttons there as it is. What about merging several of the cable-relevant buttons under a dropdown (similar to the add/edit/changelog actions)? IMO it would make sense to list the trace cable, edit cable (new), and delete cable actions under a single button. There's also the toggle button to change the cable status, but that one probably needs to stay separate as it's a Javascript function.
adam commented 2025-12-29 19:48:09 +01:00
Author
Owner
Copy Link

@dreng commented on GitHub (Oct 3, 2022):

I absolutely agree. At first I wanted to do it that way too, but I struggled a bit with choosing a suitable symbol. The symbol to change things would be the pencil, but there's another button with a pencil in this context already. A yellow dropdown menu with a cable icon could be a solution.

Another problem is that the "new" button is already a dropdown menu. It would certainly be irritating if there were an entry for "trace cable" underneath this button next to "interface", "font port", etc. Perhaps it would help to rename the entries. "interface" would then become "connect to interface". Is that roughly what you propose? Or should we just leave the trace button alone and consolidate only edit and delete?

@dreng commented on GitHub (Oct 3, 2022): I absolutely agree. At first I wanted to do it that way too, but I struggled a bit with choosing a suitable symbol. The symbol to change things would be the pencil, but there's another button with a pencil in this context already. A yellow dropdown menu with a cable icon could be a solution. Another problem is that the "new" button is already a dropdown menu. It would certainly be irritating if there were an entry for "trace cable" underneath this button next to "interface", "font port", etc. Perhaps it would help to rename the entries. "interface" would then become "connect to interface". Is that roughly what you propose? Or should we just leave the trace button alone and consolidate only edit and delete?
adam commented 2025-12-29 19:48:09 +01:00
Author
Owner
Copy Link

@dreng commented on GitHub (Oct 3, 2022):

Just to make the options clear that has been proposed:

First variant is to consolidate all of the buttons. This means that there is no trace button anymore at all if no cable is connected.
image image

Second variant is to leave trace button where it is.
image image

@dreng commented on GitHub (Oct 3, 2022): Just to make the options clear that has been proposed: First variant is to consolidate all of the buttons. This means that there is no trace button anymore at all if no cable is connected. ![image](https://user-images.githubusercontent.com/20901110/193650180-8ca093f4-ed2f-4a75-8613-da7915448641.png) ![image](https://user-images.githubusercontent.com/20901110/193650538-90dea78c-296b-4f7b-b678-42ee3930928e.png) Second variant is to leave trace button where it is. ![image](https://user-images.githubusercontent.com/20901110/193652505-968213ba-47db-45c7-8f2b-b421b717d801.png) ![image](https://user-images.githubusercontent.com/20901110/193652397-08fa81c4-84c7-4c84-9713-4623124bf94a.png)
adam commented 2025-12-29 19:48:09 +01:00
Author
Owner
Copy Link

@sieuwe commented on GitHub (Oct 6, 2022):

I would keep the trace as a separate button, we use that frequently on cables that are not attached to an interface on both sides.

@sieuwe commented on GitHub (Oct 6, 2022): I would keep the trace as a separate button, we use that frequently on cables that are not attached to an interface on both sides.
adam commented 2025-12-29 19:48:10 +01:00
Author
Owner
Copy Link

@bluikko commented on GitHub (Oct 24, 2022):

A bit off-topic but since we are discussing the buttons and their count, I wonder how frequently the "Mark planned" button is actually used - could it be moved to the drop-down that includes "Delete" and "Changelog"?

@bluikko commented on GitHub (Oct 24, 2022): A bit off-topic but since we are discussing the buttons and their count, I wonder how frequently the "Mark planned" button is actually used - could it be moved to the drop-down that includes "Delete" and "Changelog"?
adam commented 2025-12-29 19:48:10 +01:00
Author
Owner
Copy Link

@dreng commented on GitHub (Oct 24, 2022):

A bit off-topic ...

Well, yes. I would appreciate, if we could get the proposed topic done and discuss your proposal in a separate FR.

...but since we are discussing the buttons and their count, I wonder how frequently the "Mark planned" button is actually used - could it be moved to the drop-down that includes "Delete" and "Changelog"?

This button is not only a button. It is an indicator, showing the current status. Moving it to the drop-down would break this feature.

@dreng commented on GitHub (Oct 24, 2022): > A bit off-topic ... Well, yes. I would appreciate, if we could get the proposed topic done and discuss your proposal in a separate FR. > ...but since we are discussing the buttons and their count, I wonder how frequently the "Mark planned" button is actually used - could it be moved to the drop-down that includes "Delete" and "Changelog"? This button is not only a button. It is an indicator, showing the current status. Moving it to the drop-down would break this feature.
adam commented 2025-12-29 19:48:10 +01:00
Author
Owner
Copy Link

@bluikko commented on GitHub (Oct 24, 2022):

This button is not only a button. It is an indicator, showing the current status. Moving it to the drop-down would break this feature.

The reason I raised is that it was mentioned there is clutter and many buttons already. So maybe there could've been a way to reduce that clutter. But as you say, it is not possible.
I do not think further discussion on the "Mark planned" button is then necessary and I don't see how the amount of buttons could be reduced. Trace should definitely stay as a button since it is one of the most used buttons IMO.

@bluikko commented on GitHub (Oct 24, 2022): > This button is not only a button. It is an indicator, showing the current status. Moving it to the drop-down would break this feature. The reason I raised is that it was mentioned there is clutter and many buttons already. So maybe there could've been a way to reduce that clutter. But as you say, it is not possible. I do not think further discussion on the "Mark planned" button is then necessary and I don't see how the amount of buttons could be reduced. Trace should definitely stay as a button since it is one of the most used buttons IMO.
adam commented 2025-12-29 19:48:10 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Dec 24, 2022):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Dec 24, 2022): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 19:48:10 +01:00
Author
Owner
Copy Link

@dreng commented on GitHub (Dec 26, 2022):

@jeremystretch
Unfortunately, after my last reply, there was no more recourse.
I would like to kindly ask what is necessary to accept this feature request. Actually, all we need here is a decision on whether and which of the two proposed scenarios should be implemented. I can still offer to do the work.

@dreng commented on GitHub (Dec 26, 2022): @jeremystretch Unfortunately, after my last reply, there was no more recourse. I would like to kindly ask what is necessary to accept this feature request. Actually, all we need here is a decision on whether and which of the two proposed scenarios should be implemented. I can still offer to do the work.
adam commented 2025-12-29 19:48:10 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 5, 2023):

Second variant is to leave trace button where it is.

Seems like this is the preferable approach. @dreng I'll assign this to you.

@jeremystretch commented on GitHub (Jan 5, 2023): > Second variant is to leave trace button where it is. Seems like this is the preferable approach. @dreng I'll assign this to you.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#7034
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?