starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Upate all uniqueness validation to employ UniqueConstraint classes #6982

New Issue
Closed
opened 2025-12-29 19:47:27 +01:00 by adam · 0 comments
adam commented 2025-12-29 19:47:27 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Sep 14, 2022).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Replace all instances of unique_together under a model Meta class with a list of UniqueConstraint instances defined under constraints. Additionally, and custom overrides of a model's validate_unique() method should be removed where possible.

Justification

UniqueConstraint was introduced in Django 4.0 and allows for conditional evaluation. This should allow us to ditch any custom validate_unique() logic, such as what is currently defined for the Device model. The Django docs also recommend moving away from unique_together in general as it will likely be deprecated in the future.

Originally created by @jeremystretch on GitHub (Sep 14, 2022). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Replace all instances of `unique_together` under a model `Meta` class with a list of [`UniqueConstraint`](https://docs.djangoproject.com/en/4.1/ref/models/constraints/#uniqueconstraint) instances defined under `constraints`. Additionally, and custom overrides of a model's `validate_unique()` method should be removed where possible. ### Justification `UniqueConstraint` was introduced in Django 4.0 and allows for conditional evaluation. This should allow us to ditch any custom `validate_unique()` logic, such as what is currently defined for the Device model. The [Django docs](https://docs.djangoproject.com/en/4.1/ref/models/options/#unique-together) also recommend moving away from `unique_together` in general as it will likely be deprecated in the future.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 19:47:27 +01:00
adam closed this issue 2025-12-29 19:47:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6982
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?