starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Pre-commit script should only run yarn validator if relevant files have been modified #6959

New Issue
Closed
opened 2025-12-29 19:47:11 +01:00 by adam · 0 comments
adam commented 2025-12-29 19:47:11 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Sep 9, 2022).

Originally assigned to: @arthanson on GitHub.

Proposed Changes

Modify the pre-commit script so that the call to yarn validate (below) is only made if relevant files have been modified.

385a0f979e/scripts/git-hooks/pre-commit (L43-L47)

This should be doable by check for references to netbox/project-static/ in the git diff.

Justification

This check is only necessary if static files have been modified. Omitting where not needed reduces the execution time of the pre-commit script by several seconds.

Originally created by @jeremystretch on GitHub (Sep 9, 2022). Originally assigned to: @arthanson on GitHub. ### Proposed Changes Modify the [pre-commit script](https://github.com/netbox-community/netbox/blob/develop/scripts/git-hooks/pre-commit) so that the call to `yarn validate` (below) is only made if relevant files have been modified. https://github.com/netbox-community/netbox/blob/385a0f979ec460023d3d7f8e9003ddc373fb5ac3/scripts/git-hooks/pre-commit#L43-L47 This should be doable by check for references to `netbox/project-static/` in the git diff. ### Justification This check is only necessary if static files have been modified. Omitting where not needed reduces the execution time of the pre-commit script by several seconds.
adam added the type: housekeeping label 2025-12-29 19:47:11 +01:00
adam closed this issue 2025-12-29 19:47:11 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6959
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?