starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Clicking device in rackview opens new tab #6879

New Issue
Closed
opened 2025-12-29 19:46:17 +01:00 by adam · 1 comment
adam commented 2025-12-29 19:46:17 +01:00
Owner
Copy Link

Originally created by @sieuwe on GitHub (Aug 26, 2022).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.3.1

Python version

3.10

Steps to Reproduce

  1. Go to a rack view
  2. Click on a device in the rack
  3. New tab opens

Expected Behavior

The device used to open in the same window.

Observed Behavior

The device opens in a new tab.

Originally created by @sieuwe on GitHub (Aug 26, 2022). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.3.1 ### Python version 3.10 ### Steps to Reproduce 1. Go to a rack view 2. Click on a device in the rack 3. New tab opens ### Expected Behavior The device used to open in the same window. ### Observed Behavior The device opens in a new tab.
adam added the type: bugstatus: accepted labels 2025-12-29 19:46:18 +01:00
adam closed this issue 2025-12-29 19:46:18 +01:00
adam commented 2025-12-29 19:46:18 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Aug 26, 2022):

This is the default behavior of svgwrite's Hyperlink class (although we do explicitly set target="_blank" in several places). Without this, the linked content will replaced the embedded SVG on the current page. For example, if I remove the link target and then click on a device within an elevation under the rack view, the device page replaces the image:

Screenshot 2022-08-26 at 08-34-47 Rack Comms closet NetBox

I believe the appropriate fix here is to change the link attribute to target="_parent", which forces the link to replace the parent frame or document. (_top is also an option, but could break cases where the SVG image is embedded within a frame.)

This should be applied to cable trace diagrams as well.

@jeremystretch commented on GitHub (Aug 26, 2022): This is the default behavior of svgwrite's `Hyperlink` class (although we do explicitly set `target="_blank"` in several places). Without this, the linked content will replaced the embedded SVG on the current page. For example, if I remove the link target and then click on a device within an elevation under the rack view, the device page replaces the image: ![Screenshot 2022-08-26 at 08-34-47 Rack Comms closet NetBox](https://user-images.githubusercontent.com/13487278/186904571-daa9f704-cd2e-469f-8538-3fee204c5906.png) I believe the appropriate fix here is to change the link attribute to `target="_parent"`, which forces the link to replace the parent frame or document. (`_top` is also an option, but could break cases where the SVG image is embedded within a frame.) This should be applied to cable trace diagrams as well.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6879
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?