starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Linkify not sanitizing output HTML #6851

New Issue
Closed
opened 2025-12-29 19:46:04 +01:00 by adam · 0 comments
adam commented 2025-12-29 19:46:04 +01:00
Owner
Copy Link

Originally created by @0xdeadbeer on GitHub (Aug 22, 2022).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.3.1-dev

Python version

3.8

Steps to Reproduce

  1. Create a device record
  2. Create a service record
  3. Attach the service to the device
  4. Rename the service with <script>alert(1)</script> (example)
    image
  5. View the device
    image

Code where linkify is used

image

Expected Behavior

Linkify sanitizing the HTML output

Observed Behavior

Linkify not sanitizing the HTML output, allowing users to inject HTML/JS code into the website.

Originally created by @0xdeadbeer on GitHub (Aug 22, 2022). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.3.1-dev ### Python version 3.8 ### Steps to Reproduce 1. Create a device record 2. Create a service record 3. Attach the service to the device 4. Rename the service with `<script>alert(1)</script>` (example) ![image](https://user-images.githubusercontent.com/64986162/185930004-817f57b9-c53c-4f73-adf0-06e065f5e7d5.png) 5. View the device ![image](https://user-images.githubusercontent.com/64986162/185929965-84abbdda-3b6e-418c-a357-d582ec39a5aa.png) ### Code where linkify is used ![image](https://user-images.githubusercontent.com/64986162/185930353-135956a7-2000-48bf-9583-11195052e960.png) ### Expected Behavior Linkify sanitizing the HTML output ### Observed Behavior Linkify not sanitizing the HTML output, allowing users to inject HTML/JS code into the website.
adam added the type: bugstatus: accepted labels 2025-12-29 19:46:04 +01:00
adam closed this issue 2025-12-29 19:46:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6851
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?