starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Display device name, as well as interface name, when listing terminations on an L2VPN #6822

New Issue
Closed
opened 2025-12-29 19:45:46 +01:00 by adam · 5 comments
adam commented 2025-12-29 19:45:46 +01:00
Owner
Copy Link

Originally created by @candlerb on GitHub (Aug 16, 2022).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.3-beta2

Feature type

Change to existing functionality

Proposed functionality

When you view an L2VPN, the page includes a table of terminations. If those terminations are device or VM interfaces, then currently it shows only the interface name and not the device name.

This means it's very unclear, e.g. in the following these are actually two different interfaces on two different devices:
image

I propose showing the device/VM name as well.

Use case

UX: be able to see immediately which devices are involved. Currently the only way to establish which devices these terminations go to is to click through them one by one.

Database changes

None

External dependencies

None

Originally created by @candlerb on GitHub (Aug 16, 2022). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.3-beta2 ### Feature type Change to existing functionality ### Proposed functionality When you view an L2VPN, the page includes a table of terminations. If those terminations are device or VM interfaces, then currently it shows only the interface name and not the device name. This means it's very unclear, e.g. in the following these are actually two different interfaces on two different devices: ![image](https://user-images.githubusercontent.com/44789/184940298-5fc76423-52a4-4231-9d6c-c40825cd22e6.png) I propose showing the device/VM name as well. ### Use case UX: be able to see immediately which devices are involved. Currently the only way to establish which devices these terminations go to is to click through them one by one. ### Database changes None ### External dependencies None
adam added the status: acceptedtype: featurebeta labels 2025-12-29 19:45:46 +01:00
adam closed this issue 2025-12-29 19:45:46 +01:00
adam commented 2025-12-29 19:45:47 +01:00
Author
Owner
Copy Link

@candlerb commented on GitHub (Aug 16, 2022):

Ref discussion: https://github.com/netbox-community/netbox/discussions/9727#discussioncomment-3409332

Implementation issue from @DanSheps:

currently display_name for interface only shows the interface name. We could switch it to a template field, but then we will lose sorting

@candlerb commented on GitHub (Aug 16, 2022): Ref discussion: https://github.com/netbox-community/netbox/discussions/9727#discussioncomment-3409332 Implementation issue from @DanSheps: > currently `display_name` for interface only shows the interface name. We could switch it to a template field, but then we will lose sorting
adam commented 2025-12-29 19:45:47 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Aug 17, 2022):

There's already a separate column for displaying the assigned object's parent. This can be enabled by configuring the table under the L2VPN terminations list view. It probably makes sense to designate it as a default column though.

@jeremystretch commented on GitHub (Aug 17, 2022): There's already a separate column for displaying the assigned object's parent. This can be enabled by configuring the table under the L2VPN terminations list view. It probably makes sense to designate it as a default column though.
adam commented 2025-12-29 19:45:47 +01:00
Author
Owner
Copy Link

@candlerb commented on GitHub (Aug 17, 2022):

That applies to the global list of terminations (/ipam/l2vpn-terminations/), but not where I was looking, which was the view page for a particular L2VPN (/ipam/l2vpns/1/). There is a table of terminations but it is not configurable.

image

(Aside: "Assigned Object Parent" is somewhat ambiguous, because enp3s0.1000 also has a parent interface which is enp3s0 on the same device; but I can't really think of a better term)

@candlerb commented on GitHub (Aug 17, 2022): That applies to the global list of terminations (`/ipam/l2vpn-terminations/`), but not where I was looking, which was the view page for a particular L2VPN (`/ipam/l2vpns/1/`). There is a table of terminations but it is not configurable. ![image](https://user-images.githubusercontent.com/44789/185173336-12e7bb22-cba6-47c0-8e4a-08b3a715a4fb.png) (Aside: "Assigned Object Parent" is somewhat ambiguous, because `enp3s0.1000` also has a parent interface which is `enp3s0` on the same device; but I can't really think of a better term)
adam commented 2025-12-29 19:45:47 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Aug 17, 2022):

Right, but it uses the same underlying table class, so the same configuration is used. Once you add the column to the L2VPN terminations table, it will show up here too. (We should add a configure button to all such embedded tables, but that's a broader initiative.)

@jeremystretch commented on GitHub (Aug 17, 2022): Right, but it uses the same underlying table class, so the same configuration is used. Once you add the column to the L2VPN terminations table, it will show up here too. (We _should_ add a configure button to all such embedded tables, but that's a broader initiative.)
adam commented 2025-12-29 19:45:47 +01:00
Author
Owner
Copy Link

@candlerb commented on GitHub (Aug 17, 2022):

I see... if I go to /ipam/l2vpn-terminations/ and modify the table there, then return to /ipam/l2vpns/1/, it does show the extra column.

If this is set by default, then I vote for "Assigned object parent" to come before "Assigned Object"

image

(Nit: change capitalization to "Assigned Object Parent" for consistency)

@candlerb commented on GitHub (Aug 17, 2022): I see... if I go to `/ipam/l2vpn-terminations/` and modify the table there, then return to `/ipam/l2vpns/1/`, it does show the extra column. If this is set by default, then I vote for "Assigned object parent" to come before "Assigned Object" ![image](https://user-images.githubusercontent.com/44789/185175615-024e2af9-e81c-4a12-8e90-b773cdc7f765.png) (Nit: change capitalization to "Assigned Object Parent" for consistency)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label beta status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6822
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?