starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Allow vlans within devices site group to be assigned to interface #6761

New Issue
Closed
opened 2025-12-29 19:45:08 +01:00 by adam · 3 comments
adam commented 2025-12-29 19:45:08 +01:00
Owner
Copy Link

Originally created by @DanSheps on GitHub (Aug 2, 2022).

NetBox version

3.2.7

Feature type

Change to existing functionality

Proposed functionality

Change the functioning of the "available_on_device" parameter for the vlan API to additionally include the devices site_group when looking at VLANs.

Currently, available_on_device goes up "1 level" to the site when searching for vlans available on device. By allowing it to go up to the site's group you can include stretched L2 networks across multiple sites.

This would also likely require changes to clean() and save() to allow for these assignments.

Use case

Lets say you have "Switch 1" in "Site A" but only services "Site B" because of building constraints. You may have an identical VLAN in Site A already but is distinct you then have a VLAN collision within "Site A" and cannot save the VLAN due to model constraints. This would work as a vlan group, however you lose your direct site relation because of it and have to traverse the vlan groups.

Database changes

No changes required

External dependencies

No external dependencies

Originally created by @DanSheps on GitHub (Aug 2, 2022). ### NetBox version 3.2.7 ### Feature type Change to existing functionality ### Proposed functionality Change the functioning of the "available_on_device" parameter for the vlan API to additionally include the devices site_group when looking at VLANs. Currently, available_on_device goes up "1 level" to the site when searching for vlans available on device. By allowing it to go up to the site's group you can include stretched L2 networks across multiple sites. This would also likely require changes to clean() and save() to allow for these assignments. ### Use case Lets say you have "Switch 1" in "Site A" but only services "Site B" because of building constraints. You may have an identical VLAN in Site A already but is distinct you then have a VLAN collision within "Site A" and cannot save the VLAN due to model constraints. This would work as a vlan group, however you lose your direct site relation because of it and have to traverse the vlan groups. ### Database changes No changes required ### External dependencies No external dependencies
adam added the type: featurepending closurestatus: under review labels 2025-12-29 19:45:08 +01:00
adam closed this issue 2025-12-29 19:45:08 +01:00
adam commented 2025-12-29 19:45:09 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Aug 2, 2022):

Implementation

Change:

ff3fcb8134/netbox/ipam/querysets.py (L69-L74)

To:


        return self.filter(
            Q(group__in=VLANGroup.objects.filter(q)) |
            Q(site=device.site) |
            Q(site__group=device.site.group) |
            Q(group__scope_id__isnull=True, site__isnull=True) |  # Global group VLANs
            Q(group__isnull=True, site__isnull=True)  # Global VLANs
        )

Change:

ff3fcb8134/netbox/dcim/models/device_components.py (L761)

To:

if self.untagged_vlan and (self.untagged_vlan.site not in [self.device.site, None] or self.untagged_vlan.site.group not in [self.device.site.group, None]):
@DanSheps commented on GitHub (Aug 2, 2022): ### Implementation Change: https://github.com/netbox-community/netbox/blob/ff3fcb8134c229033453afadcc1e315c52f3fd20/netbox/ipam/querysets.py#L69-L74 To: ```python return self.filter( Q(group__in=VLANGroup.objects.filter(q)) | Q(site=device.site) | Q(site__group=device.site.group) | Q(group__scope_id__isnull=True, site__isnull=True) | # Global group VLANs Q(group__isnull=True, site__isnull=True) # Global VLANs ) ``` Change: https://github.com/netbox-community/netbox/blob/ff3fcb8134c229033453afadcc1e315c52f3fd20/netbox/dcim/models/device_components.py#L761 To: ```python if self.untagged_vlan and (self.untagged_vlan.site not in [self.device.site, None] or self.untagged_vlan.site.group not in [self.device.site.group, None]): ```
adam commented 2025-12-29 19:45:09 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Oct 2, 2022):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Oct 2, 2022): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 19:45:09 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Nov 2, 2022):

This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.

@github-actions[bot] commented on GitHub (Nov 2, 2022): This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pending closure status: under review type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6761
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?