starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Remove delete button from UI with tabs and subcomponents. #6737

New Issue
Closed
opened 2025-12-29 19:44:47 +01:00 by adam · 14 comments
adam commented 2025-12-29 19:44:47 +01:00
Owner
Copy Link

Originally created by @pdenessen on GitHub (Jul 29, 2022).

NetBox version

v3.2.7

Feature type

Change to existing functionality

Proposed functionality

If you have a model like a device with a tab with several subcomponents, like bays or interfaces, and you select a nr of them, then you will see 2 delete buttons. One on the top right corner, for deleting the whole device and one at the bottom of the list for selecting just the selected items.
If this list is very long and you select just a few entries on the top of this list then you even don't see the correct button on the bottom of the list but only the delete button for the device.
This is very confusing and especially new users can click the wrong button and then select the whole device. This happened to me twice, where after I had to add the whole device with its components again.

Use case

Remove the delete button for the device in the upper right corner from the UI when one of the tabs is selected to avoid confusion.

Database changes

No database changes are needed, just UI adaptations.

External dependencies

No response

Originally created by @pdenessen on GitHub (Jul 29, 2022). ### NetBox version v3.2.7 ### Feature type Change to existing functionality ### Proposed functionality If you have a model like a device with a tab with several subcomponents, like bays or interfaces, and you select a nr of them, then you will see 2 delete buttons. One on the top right corner, for deleting the whole device and one at the bottom of the list for selecting just the selected items. If this list is very long and you select just a few entries on the top of this list then you even don't see the correct button on the bottom of the list but only the delete button for the device. This is very confusing and especially new users can click the wrong button and then select the whole device. This happened to me twice, where after I had to add the whole device with its components again. ### Use case Remove the delete button for the device in the upper right corner from the UI when one of the tabs is selected to avoid confusion. ### Database changes No database changes are needed, just UI adaptations. ### External dependencies _No response_
adam added the type: featurepending closure labels 2025-12-29 19:44:47 +01:00
adam closed this issue 2025-12-29 19:44:47 +01:00
adam commented 2025-12-29 19:44:48 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jul 29, 2022):

I don't see how this is confusing. The object edit and delete buttons are always at the top right corner, and the bulk actions for list objects are always at the bottom left.

@jeremystretch commented on GitHub (Jul 29, 2022): I don't see how this is confusing. The object edit and delete buttons are always at the top right corner, and the bulk actions for list objects are always at the bottom left.
adam commented 2025-12-29 19:44:48 +01:00
Author
Owner
Copy Link

@pdenessen commented on GitHub (Jul 29, 2022):

Hi Jeremy I have added 2 screenshots to visualize the problem.
In screenshot 1 dont you see the correcte delete button on the bottom if you don't scroll down.
In screenshot 2 do you have 2 delete buttons.
Screenshot_1
Screenshot_3

@pdenessen commented on GitHub (Jul 29, 2022): Hi Jeremy I have added 2 screenshots to visualize the problem. In screenshot 1 dont you see the correcte delete button on the bottom if you don't scroll down. In screenshot 2 do you have 2 delete buttons. ![Screenshot_1](https://user-images.githubusercontent.com/11139454/181763676-1e273d1e-9e4a-434d-8c54-55eac8f46377.png) ![Screenshot_3](https://user-images.githubusercontent.com/11139454/181763763-ce6f56e5-f3df-4fde-9dd9-5d6c823d34b5.png)
adam commented 2025-12-29 19:44:48 +01:00
Author
Owner
Copy Link

@PieterL75 commented on GitHub (Jul 29, 2022):

I do follow this. We had several users clicking that 'delete' button on the top, if they selected items from a list.
I 'solved' that by removing the 'delete device/vm' rights from all users, except some admins

Or relabel that top right button to 'Delete Device' ?

@PieterL75 commented on GitHub (Jul 29, 2022): I do follow this. We had several users clicking that 'delete' button on the top, if they selected items from a list. I 'solved' that by removing the 'delete device/vm' rights from all users, except some admins Or relabel that top right button to 'Delete Device' ?
adam commented 2025-12-29 19:44:49 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Jul 29, 2022):

I could get behind changing the button to be "Delete [object]" for the top one.

@DanSheps commented on GitHub (Jul 29, 2022): I could get behind changing the button to be "Delete [object]" for the top one.
adam commented 2025-12-29 19:44:49 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jul 29, 2022):

I could get behind changing the button to be "Delete [object]" for the top one.

The object buttons all used to have that format, however it wastes a lot of screen space, especially for models with longer names. If anything, I think it would make more sense to change the bulk operation buttons to e.g. "delete selected."

@jeremystretch commented on GitHub (Jul 29, 2022): > I could get behind changing the button to be "Delete [object]" for the top one. The object buttons all used to have that format, however it wastes a lot of screen space, especially for models with longer names. If anything, I think it would make more sense to change the bulk operation buttons to e.g. "delete selected."
adam commented 2025-12-29 19:44:49 +01:00
Author
Owner
Copy Link

@PieterL75 commented on GitHub (Jul 29, 2022):

Or go for the same system as in an object list.
Only show the edit button, and place the delete in a drop-down

@PieterL75 commented on GitHub (Jul 29, 2022): Or go for the same system as in an object list. Only show the edit button, and place the delete in a drop-down
adam commented 2025-12-29 19:44:49 +01:00
Author
Owner
Copy Link

@pdenessen commented on GitHub (Jul 30, 2022):

Hi Pieter, this works only if you have to delete a few items. This will be a lot of work if you have a whole list. Best would be to hide the delete button in the upper right when you see tabs listing items other then the device itself. Just keep the the delete button with the main tab.

@pdenessen commented on GitHub (Jul 30, 2022): Hi Pieter, this works only if you have to delete a few items. This will be a lot of work if you have a whole list. Best would be to hide the delete button in the upper right when you see tabs listing items other then the device itself. Just keep the the delete button with the main tab.
adam commented 2025-12-29 19:44:50 +01:00
Author
Owner
Copy Link

@PieterL75 commented on GitHub (Jul 30, 2022):

What I meant is, that the top right button could be hidden under the edit button, just like the edit/delete buttons on a table like.
Then the delete button of the object works not be directly visible, but the item delete buttons are still there

@PieterL75 commented on GitHub (Jul 30, 2022): What I meant is, that the top right button could be hidden under the edit button, just like the edit/delete buttons on a table like. Then the delete button of the object works not be directly visible, but the item delete buttons are still there
adam commented 2025-12-29 19:44:50 +01:00
Author
Owner
Copy Link

@pwrgfi commented on GitHub (Jul 31, 2022):

Not too muddy the waters too much with regards to this specific proposal "remove delete button" - but then I've also noticed this sentence in the op:

If this list is very long and you select just a few entries on the top of this list then you even don't see the correct button on the bottom of the list but only the delete button for the device.

I agree and have been bitten by the same issue (once) and I found this Github issue just when I was about to open a new issue for UX enhancement that was more about "reduce amount of mouse scrolling", but might alleviate this issue as well:

At the moment, users need to scroll unnecessarily in many contexts - with tables, the bulk action buttons are shown on the bottom of the table only. My UX suggestion was to suggest to add them at the beginning of the table, too. Otherwise you spend 80% of your time scrolling if, for some reason, you've got many entries in the view and you just want to, say, delete, just a few of them.

  • alternative suggestion: leave the buttons at the bottom only, but not at the bottom of the table, but as persistent, non-scrolling footer that is always visible. This way, even if your table is 1000 entries long and you want to delete items 490, 501 and 530 you don't need to scroll at all after selecting all relevant items. So, the same as the pinned top of the page with the global search and the user preferences, but at the bottom.
  • adding "... selected" to the bulk action buttons, as suggested by @jeremystretch was another UX suggestion I'd wanted to log in GitHub, precisely because at the moment there is a button at the top and one at the button that is labelled the same but does different things altogether. If the table-level buttons were displayed at the top or in a permanently visible footer it would be even more important to be able to differentiate the impact of the buttons.
@pwrgfi commented on GitHub (Jul 31, 2022): Not too muddy the waters too much with regards to this specific proposal "remove delete button" - but then I've also noticed this sentence in the op: > If this list is very long and you select just a few entries on the top of this list then you even don't see the correct button on the bottom of the list but only the delete button for the device. I agree and have been bitten by the same issue (once) and I found this Github issue just when I was about to open a new issue for UX enhancement that was more about "reduce amount of mouse scrolling", but might alleviate this issue as well: At the moment, users need to scroll unnecessarily in many contexts - with tables, the bulk action buttons are shown on the bottom of the table only. My UX suggestion was to suggest to add them at the beginning of the table, too. Otherwise you spend 80% of your time scrolling if, for some reason, you've got many entries in the view and you just want to, say, delete, just a few of them. - alternative suggestion: leave the buttons at the bottom only, but not at the bottom of the table, but as persistent, non-scrolling footer that is always visible. This way, even if your table is 1000 entries long and you want to delete items 490, 501 and 530 you don't need to scroll at all after selecting all relevant items. So, the same as the pinned top of the page with the global search and the user preferences, but at the bottom. - adding "... selected" to the bulk action buttons, as suggested by @jeremystretch was another UX suggestion I'd wanted to log in GitHub, precisely because at the moment there is a button at the top and one at the button that is labelled the same but does different things altogether. If the table-level buttons were displayed at the top or in a permanently visible footer it would be even more important to be able to differentiate the impact of the buttons.
adam commented 2025-12-29 19:44:50 +01:00
Author
Owner
Copy Link

@PieterL75 commented on GitHub (Jul 31, 2022):

I opened a similar 'less scrolling' idea here #9386.
But I think we need to get to a good compromise here. How to get rid of the confusion that can exists when 2 different objects (a device and device interfaces) are shown on one page

@PieterL75 commented on GitHub (Jul 31, 2022): I opened a similar 'less scrolling' idea here #9386. But I think we need to get to a good compromise here. How to get rid of the confusion that can exists when 2 different objects (a device and device interfaces) are shown on one page
adam commented 2025-12-29 19:44:50 +01:00
Author
Owner
Copy Link

@pdenessen commented on GitHub (Aug 18, 2022):

If you have a screen with the focus on the device (First tab: device) then the visible buttons should be for the device. If you have however a tab wit a lot of components (interfaces, modules, devices etc) listed then the focus is on this list and the buttons should also be applicable for this list.
So my proposal is to keep the "device"- buttons for the 1st device tab and replace these buttons on the tabs with lists to handle these listed elements.

@pdenessen commented on GitHub (Aug 18, 2022): If you have a screen with the focus on the device (First tab: device) then the visible buttons should be for the device. If you have however a tab wit a lot of components (interfaces, modules, devices etc) listed then the focus is on this list and the buttons should also be applicable for this list. So my proposal is to keep the "device"- buttons for the 1st device tab and replace these buttons on the tabs with lists to handle these listed elements.
adam commented 2025-12-29 19:44:50 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Oct 18, 2022):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Oct 18, 2022): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 19:44:51 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Nov 18, 2022):

This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.

@github-actions[bot] commented on GitHub (Nov 18, 2022): This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.
adam commented 2025-12-29 19:44:51 +01:00
Author
Owner
Copy Link

@PieterL75 commented on GitHub (Nov 18, 2022):

Any other thoughts?
What I see is

  • change the bottom 'delete' button to 'delete selected' (also for the edit one)
  • change the ui to reduce the scrolling, and always show the bottom buttons
    P
@PieterL75 commented on GitHub (Nov 18, 2022): Any other thoughts? What I see is - change the bottom 'delete' button to 'delete selected' (also for the edit one) - change the ui to reduce the scrolling, and always show the bottom buttons P
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pending closure type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6737
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?