starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Add NEEDS_LOGIN_FOR_SEARCH #6644

New Issue
Closed
opened 2025-12-29 19:43:26 +01:00 by adam · 2 comments
adam commented 2025-12-29 19:43:26 +01:00
Owner
Copy Link

Originally created by @johannwagner on GitHub (Jul 11, 2022).

NetBox version

v3.1.11

Feature type

New functionality

Proposed functionality

We propose a new configuration flag for NEEDS_LOGIN_FOR_SEARCH. This enforces a redirect to the login page, if an unauthenicated user wants to start a search.

Use case

In our Netbox configuration, we only allow viewing elements, if the user is logged in. This results into an empty result, if the user searches without authentication, which is confusing. The same search as authenticated user would result in at least one match.

Database changes

None

External dependencies

None

Originally created by @johannwagner on GitHub (Jul 11, 2022). ### NetBox version v3.1.11 ### Feature type New functionality ### Proposed functionality We propose a new configuration flag for `NEEDS_LOGIN_FOR_SEARCH`. This enforces a redirect to the login page, if an unauthenicated user wants to start a search. ### Use case In our Netbox configuration, we only allow viewing elements, if the user is logged in. This results into an empty result, if the user searches without authentication, which is confusing. The same search as authenticated user would result in at least one match. ### Database changes None ### External dependencies None
adam closed this issue 2025-12-29 19:43:27 +01:00
adam commented 2025-12-29 19:43:27 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (Jul 11, 2022):

I'm not sure I understand your use case. If you only allow logged in users to view objects, why is setting LOGIN_REQUIRED not sufficient for hiding the search field?

@kkthxbye-code commented on GitHub (Jul 11, 2022): I'm not sure I understand your use case. If you only allow logged in users to view objects, why is setting `LOGIN_REQUIRED` not sufficient for hiding the search field?
adam commented 2025-12-29 19:43:27 +01:00
Author
Owner
Copy Link

@johannwagner commented on GitHub (Jul 11, 2022):

You are totally correct. Sorry for inconvenience, this solves our issue.

@johannwagner commented on GitHub (Jul 11, 2022): You are totally correct. Sorry for inconvenience, this solves our issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6644
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?