Refactor actions declarations for ObjectListView #6608

New Issue

adam · 2025-12-29T19:43:03+01:00

adam commented

2025-12-29 19:43:03 +01:00

Originally created by @jeremystretch on GitHub (Jun 29, 2022).

Proposed Changes

ObjectListView currently has two attributes related to permitted actions: actions (a tuple of action names) and action_perms (a dictionary mapping these names to required permissions. By default, these are:

actions = ('add', 'import', 'export', 'bulk_edit', 'bulk_delete')
action_perms = defaultdict(set, **{
    'add': {'add'},
    'import': {'add'},
    'bulk_edit': {'change'},
    'bulk_delete': {'delete'},
})

The proposal here is to merge these into a single dictionary named actions, i.e.:

actions = defaultdict(set, **{
    'add': {'add'},
    'import': {'add'},
    'export': {},
    'bulk_edit': {'change'},
    'bulk_delete': {'delete'},
})

Actions which do not require any permissions map to an empty set.

Justification

This approach simplifies the declaration of actions and their required permissions.

Originally created by @jeremystretch on GitHub (Jun 29, 2022). ### Proposed Changes ObjectListView currently has two attributes related to permitted actions: `actions` (a tuple of action names) and `action_perms` (a dictionary mapping these names to required permissions. By default, these are: ```python actions = ('add', 'import', 'export', 'bulk_edit', 'bulk_delete') action_perms = defaultdict(set, **{ 'add': {'add'}, 'import': {'add'}, 'bulk_edit': {'change'}, 'bulk_delete': {'delete'}, }) ``` The proposal here is to merge these into a single dictionary named `actions`, i.e.: ```python actions = defaultdict(set, **{ 'add': {'add'}, 'import': {'add'}, 'export': {}, 'bulk_edit': {'change'}, 'bulk_delete': {'delete'}, }) ``` Actions which do not require any permissions map to an empty set. ### Justification This approach simplifies the declaration of actions and their required permissions.

adam added the type: housekeeping topic: plugins labels 2025-12-29 19:43:03 +01:00

adam closed this issue

2025-12-29 19:43:03 +01:00

adam commented

2025-12-29 19:43:04 +01:00

@jeremystretch commented on GitHub (Jun 29, 2022):

Disregard; we did it this way specifically to allow a view to declare a subset of actions without having to redefine the permission mappings.

@jeremystretch commented on GitHub (Jun 29, 2022): Disregard; we did it this way specifically to allow a view to declare a subset of actions without having to redefine the permission mappings.

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#6608