starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Add Location to Circuit Termination #6596

New Issue
Closed
opened 2025-12-29 19:42:48 +01:00 by adam · 7 comments
adam commented 2025-12-29 19:42:48 +01:00
Owner
Copy Link

Originally created by @gjvc on GitHub (Jun 24, 2022).

Originally assigned to: @arthanson on GitHub.

NetBox version

v3.2.5

Feature type

Data model extension

Proposed functionality

When editing a circuit termination, i can specify "Region", "Site group", and "Site", but not "Location".

I would like to specify the "Location" field (optionally) as part of the termination.

Use case

We have cross-connects between our cage and cages of other tenants in Equinix. Each tenant's cage is identified by placing the Equinix cage ID in the "Location" field, and this works well in the "Region / Site Group / Site / Location" containment hierarchy.

Right now I am having to specify the tenant's cage as the "Site", because "Location" is not available to me when editing the circuit termination, which makes for something of an impedance mismatch.

Database changes

add foreign key from CircuitTerminations to Location, (where null=True)

External dependencies

None

Originally created by @gjvc on GitHub (Jun 24, 2022). Originally assigned to: @arthanson on GitHub. ### NetBox version v3.2.5 ### Feature type Data model extension ### Proposed functionality When editing a circuit termination, i can specify "Region", "Site group", and "Site", but not "Location". I would like to specify the "Location" field (optionally) as part of the termination. ### Use case We have cross-connects between our cage and cages of other tenants in Equinix. Each tenant's cage is identified by placing the Equinix cage ID in the "Location" field, and this works well in the "Region / Site Group / Site / Location" containment hierarchy. Right now I am having to specify the tenant's cage as the "Site", because "Location" is not available to me when editing the circuit termination, which makes for something of an impedance mismatch. ### Database changes add foreign key from `CircuitTerminations` to `Location`, (where `null=True`) ### External dependencies None
adam added the status: acceptedtype: featurenetboxbreaking changecomplexity: low labels 2025-12-29 19:42:48 +01:00
adam closed this issue 2025-12-29 19:42:48 +01:00
adam commented 2025-12-29 19:42:48 +01:00
Author
Owner
Copy Link

@gjvc commented on GitHub (Jun 25, 2022):

basic diff (no migration or PR yet etc) here https://github.com/netbox-community/netbox/compare/develop...gjvc:9604-add-location-to-circuittermination for clarity / discussion.

  • added location field to ProviderForm
  • added location foreign key to CircuitTermination
  • added location field to circuittermination_edit.html template
  • updated circuits table to display Side A/B value via this logic:
    - if location is set, show location
    - if site only is set, show site (as before)
    - if provider_network only is set, show provider_network (as before)
@gjvc commented on GitHub (Jun 25, 2022): basic diff (no migration or PR yet etc) here https://github.com/netbox-community/netbox/compare/develop...gjvc:9604-add-location-to-circuittermination for clarity / discussion. - added location field to ProviderForm - added location foreign key to CircuitTermination - added location field to circuittermination_edit.html template - updated circuits table to display Side A/B value via this logic: - if location is set, show location - if site only is set, show site (as before) - if provider_network only is set, show provider_network (as before)
adam commented 2025-12-29 19:42:48 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Sep 12, 2022):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Sep 12, 2022): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 19:42:49 +01:00
Author
Owner
Copy Link

@eronlloyd commented on GitHub (Sep 13, 2022):

As a service provider trying to get better PoP records for interconnects, etc., I think this could help. @gjvc do you think you can complete your code as a PR in the near future?

@eronlloyd commented on GitHub (Sep 13, 2022): As a service provider trying to get better PoP records for interconnects, etc., I think this could help. @gjvc do you think you can complete your code as a PR in the near future?
adam commented 2025-12-29 19:42:49 +01:00
Author
Owner
Copy Link

@gjvc commented on GitHub (Sep 14, 2022):

@eronlloyd Certainly can! I will make a diff against develop this week and create a PR. Thank you for your consideration. :-)

@gjvc commented on GitHub (Sep 14, 2022): @eronlloyd Certainly can! I will make a diff against develop this week and create a PR. Thank you for your consideration. :-)
adam commented 2025-12-29 19:42:49 +01:00
Author
Owner
Copy Link

@gjvc commented on GitHub (Dec 1, 2022):

@jeremystretch would you be able to provide a milestone for this?

@gjvc commented on GitHub (Dec 1, 2022): @jeremystretch would you be able to provide a milestone for this?
adam commented 2025-12-29 19:42:49 +01:00
Author
Owner
Copy Link

@GoldyXXD commented on GitHub (Jul 21, 2023):

This would be very handy for us as well. For us Sites is more of a 'compound' large area. Whereas Locations is down to the building within that area. And multiple circuits could come into different buildings.

@GoldyXXD commented on GitHub (Jul 21, 2023): This would be very handy for us as well. For us Sites is more of a 'compound' large area. Whereas Locations is down to the building within that area. And multiple circuits could come into different buildings.
adam commented 2025-12-29 19:42:49 +01:00
Author
Owner
Copy Link

@lorsung commented on GitHub (Jul 18, 2024):

I agree with @GoldyXXD, we have sites with multiple demarcs and this would be really helpful.

@lorsung commented on GitHub (Jul 18, 2024): I agree with @GoldyXXD, we have sites with multiple demarcs and this would be really helpful.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label breaking change complexity: low netbox status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6596
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?