starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Wrong redirect url for module components creation #6538

New Issue
Closed
opened 2025-12-29 19:42:07 +01:00 by adam · 2 comments
adam commented 2025-12-29 19:42:07 +01:00
Owner
Copy Link

Originally created by @marinakosolap on GitHub (Jun 6, 2022).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.2.4

Python version

3.8

Steps to Reproduce

  1. Create module
  2. Go to module and click add component
  3. Create some component

https://user-images.githubusercontent.com/46861251/172150867-9d59563b-e580-41ea-98de-5b55c8f0d8f7.mov

Expected Behavior

After module component creation page with module components is opened

Observed Behavior

After module component creation page with device components is opened (if there is device with such id (module id). In other case there is an error that such page wasn't found)
image

Originally created by @marinakosolap on GitHub (Jun 6, 2022). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.2.4 ### Python version 3.8 ### Steps to Reproduce 1. Create module 2. Go to module and click add component 3. Create some component https://user-images.githubusercontent.com/46861251/172150867-9d59563b-e580-41ea-98de-5b55c8f0d8f7.mov ### Expected Behavior After module component creation page with module components is opened ### Observed Behavior After module component creation page with device components is opened (if there is device with such id (module id). In other case there is an error that such page wasn't found) <img width="889" alt="image" src="https://user-images.githubusercontent.com/46861251/172151296-883689dd-67f6-4a90-87ec-86c76fce0365.png">
adam added the type: bugstatus: accepted labels 2025-12-29 19:42:07 +01:00
adam closed this issue 2025-12-29 19:42:07 +01:00
adam commented 2025-12-29 19:42:08 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (Jun 6, 2022):

The returnurl is indeed set to return to the pk of the module instead of the pk of the modules device, which is a bug.

3fbf1f7e71/netbox/templates/dcim/module.html (L21)

Not sure if I understand what you mean by:

Expected Behavior

After module component creation page with module components is opened

Could you specify or just give an example of the URL you want to be the return?

Fixing the bug would return to the same view as before, just on the right device. I'm not totally sure it is better to return to the module (if that is indeed what you are suggesting).

@kkthxbye-code commented on GitHub (Jun 6, 2022): The returnurl is indeed set to return to the pk of the module instead of the pk of the modules device, which is a bug. https://github.com/netbox-community/netbox/blob/3fbf1f7e71801487abd3524797298d82dca4db4f/netbox/templates/dcim/module.html#L21 Not sure if I understand what you mean by: > #### Expected Behavior > After module component creation page with module components is opened Could you specify or just give an example of the URL you want to be the return? Fixing the bug would return to the same view as before, just on the right device. I'm not totally sure it is better to return to the module (if that is indeed what you are suggesting).
adam commented 2025-12-29 19:42:08 +01:00
Author
Owner
Copy Link

@marinakosolap commented on GitHub (Jun 6, 2022):

So, I suppose that when we add console port to module we should show console ports of this module.
Something like this - https://demo.netbox.dev/dcim/console-ports/?module_id=1

@marinakosolap commented on GitHub (Jun 6, 2022): So, I suppose that when we add console port to module we should show console ports of this module. Something like this - https://demo.netbox.dev/dcim/console-ports/?module_id=1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6538
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?