starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Webhooks fire erroneously when custom scripts fail causing a transaction rolback #6531

New Issue
Closed
opened 2025-12-29 19:42:01 +01:00 by adam · 0 comments
adam commented 2025-12-29 19:42:01 +01:00
Owner
Copy Link

Originally created by @kkthxbye-code on GitHub (Jun 2, 2022).

Originally assigned to: @kkthxbye-code on GitHub.

NetBox version

v3.2.4

Python version

3.9

Steps to Reproduce

  • Register a webhook handler for the Contact object type.
  • Run the following custom script:
from extras.scripts import Script
from tanancy.models import Contact

class MyScript(Script):
    def run(self, data, commit):
        contact = Contact(name="test")
        contact.full_clean()
        contact.save()
        raise Exception("Exception")

Expected Behavior

No webhooks are sent as the script failed and the database transaction is rolled back.

Observed Behavior

A weebhook is fired for the contact object.

Originally created by @kkthxbye-code on GitHub (Jun 2, 2022). Originally assigned to: @kkthxbye-code on GitHub. ### NetBox version v3.2.4 ### Python version 3.9 ### Steps to Reproduce * Register a webhook handler for the Contact object type. * Run the following custom script: ``` from extras.scripts import Script from tanancy.models import Contact class MyScript(Script): def run(self, data, commit): contact = Contact(name="test") contact.full_clean() contact.save() raise Exception("Exception") ``` ### Expected Behavior No webhooks are sent as the script failed and the database transaction is rolled back. ### Observed Behavior A weebhook is fired for the contact object.
adam added the type: bugstatus: accepted labels 2025-12-29 19:42:01 +01:00
adam closed this issue 2025-12-29 19:42:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6531
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?