starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Upgrade django-debug-toolbar to 3.3.0+ #6524

New Issue
Closed
opened 2025-12-29 19:41:58 +01:00 by adam · 2 comments
adam commented 2025-12-29 19:41:58 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (May 31, 2022).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Upgrade django-debug-toolbar to the most recent stable release. I've held back on this because upgrading to v3.3.0 or later results in very noisy test output, and I'm not sure why. Need to dig into this some.

Justification

Keeps the dependency current

Originally created by @jeremystretch on GitHub (May 31, 2022). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Upgrade `django-debug-toolbar` to the most recent stable release. I've held back on this because upgrading to v3.3.0 or later results in very noisy test output, and I'm not sure why. Need to dig into this some. ### Justification Keeps the dependency current
adam added the status: acceptedtype: housekeeping labels 2025-12-29 19:41:58 +01:00
adam closed this issue 2025-12-29 19:41:58 +01:00
adam commented 2025-12-29 19:41:59 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (Jun 1, 2022):

The change responsible:

https://github.com/jazzband/django-debug-toolbar/pull/1603/files#diff-e3e1201763719bc0636597a8ff2b6bf5c2bac11431ea8b59929bf885a2737357R48-R65

When there's no logging handler set, django-debug-toolbar adds one.

Adding something like this:

LOGGING = {
    'version': 1,
    'disable_existing_loggers': True
}

Or this:

LOGGING = {
    'version': 1,
    'disable_existing_loggers': True,
    'handlers': {
        'console': {
            'class': 'logging.StreamHandler',
        },
    },
    'loggers': {
        'django': {
            'handlers': ['console'],
            'level': 'DEBUG',
        },
    },
}

To the logging config prevents the log spam. Not sure if we want any logging in the tests.

We could also just not load django-debug-toolbar when testing, not sure if its useful to load it.

@kkthxbye-code commented on GitHub (Jun 1, 2022): The change responsible: https://github.com/jazzband/django-debug-toolbar/pull/1603/files#diff-e3e1201763719bc0636597a8ff2b6bf5c2bac11431ea8b59929bf885a2737357R48-R65 When there's no logging handler set, django-debug-toolbar adds one. Adding something like this: ``` LOGGING = { 'version': 1, 'disable_existing_loggers': True } ``` Or this: ``` LOGGING = { 'version': 1, 'disable_existing_loggers': True, 'handlers': { 'console': { 'class': 'logging.StreamHandler', }, }, 'loggers': { 'django': { 'handlers': ['console'], 'level': 'DEBUG', }, }, } ``` To the logging config prevents the log spam. Not sure if we want any logging in the tests. We could also just not load django-debug-toolbar when testing, not sure if its useful to load it.
adam commented 2025-12-29 19:41:59 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jun 1, 2022):

When there's no logging handler set, django-debug-toolbar adds one.

Thanks @kkthxbye-code! This was starting to bug me.

@jeremystretch commented on GitHub (Jun 1, 2022): > When there's no logging handler set, django-debug-toolbar adds one. Thanks @kkthxbye-code! This was starting to bug me.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6524
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?