starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Move the application of user preferences in BaseTable to its configure() method #6446

New Issue
Closed
opened 2025-12-29 19:40:49 +01:00 by adam · 3 comments
adam commented 2025-12-29 19:40:49 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (May 4, 2022).

Proposed Changes

NetBox's BaseTable class accepts a user instance as an optional argument for instantiation. If provided, the table will be configured per the user's preferences (if any). The class also provides a configure() method, which handles pagination and ordering per the request.

As the configure() method already has access to the current request, it makes sense to handle the application of user preferences here as well. The column selection logic can be moved from __init__() to configure().

Justification

This would obviate the need to pass the user to the table during instantiation, reducing boilerplate and avoiding errant omissions (see #9260).

Originally created by @jeremystretch on GitHub (May 4, 2022). ### Proposed Changes NetBox's `BaseTable` class accepts a user instance as an optional argument for instantiation. If provided, the table will be configured per the user's preferences (if any). The class also provides a `configure()` method, which handles pagination and ordering per the request. As the `configure()` method already has access to the current request, it makes sense to handle the application of user preferences here as well. The column selection logic can be moved from `__init__()` to `configure()`. ### Justification This would obviate the need to pass the user to the table during instantiation, reducing boilerplate and avoiding errant omissions (see #9260).
adam added the type: housekeeping label 2025-12-29 19:40:49 +01:00
adam closed this issue 2025-12-29 19:40:49 +01:00
adam commented 2025-12-29 19:40:50 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jun 23, 2022):

Need to dig further into this; it may require additional juggling of the table instantiation logic.

@jeremystretch commented on GitHub (Jun 23, 2022): Need to dig further into this; it may require additional juggling of the table instantiation logic.
adam commented 2025-12-29 19:40:50 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Aug 23, 2022):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Aug 23, 2022): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 19:40:50 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Sep 13, 2022):

Going to close this out as it would likely be more effort than it's worth. Something we can revisit in the future if needed.

@jeremystretch commented on GitHub (Sep 13, 2022): Going to close this out as it would likely be more effort than it's worth. Something we can revisit in the future if needed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6446
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?