starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Apply user table preferences under object detail views #6422

New Issue
Closed
opened 2025-12-29 19:40:32 +01:00 by adam · 6 comments
adam commented 2025-12-29 19:40:32 +01:00
Owner
Copy Link

Originally created by @LHBL2003 on GitHub (Apr 29, 2022).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.2.1

Feature type

New functionality

Proposed functionality

I navigate to the "Devices" and click on "Role" = Patch Panel. Now all patch panels are displayed. However, I cannot display a comment here. Because the button Configure Table does not exist.

Use case

Important information for better identification is not displayed. e.g. Comments. The display of additional information makes the work much more efficient.

Database changes

No response

External dependencies

No response

Originally created by @LHBL2003 on GitHub (Apr 29, 2022). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.2.1 ### Feature type New functionality ### Proposed functionality I navigate to the "Devices" and click on "Role" = Patch Panel. Now all patch panels are displayed. However, I cannot display a comment here. Because the button Configure Table does not exist. ### Use case Important information for better identification is not displayed. e.g. Comments. The display of additional information makes the work much more efficient. ### Database changes _No response_ ### External dependencies _No response_
adam added the status: acceptedtype: feature labels 2025-12-29 19:40:32 +01:00
adam closed this issue 2025-12-29 19:40:33 +01:00
adam commented 2025-12-29 19:40:33 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 3, 2022):

I navigate to the "Devices" and click on "Role" = Patch Panel. Now all patch panels are displayed. However, I cannot display a comment here. Because the button Configure Table does not exist.

I'm not sure I follow. The table configuration button is present on the devices list.
Screenshot 2022-05-03 at 09-16-20 Devices NetBox

@jeremystretch commented on GitHub (May 3, 2022): > I navigate to the "Devices" and click on "Role" = Patch Panel. Now all patch panels are displayed. However, I cannot display a comment here. Because the button Configure Table does not exist. I'm not sure I follow. The table configuration button is present on the devices list. ![Screenshot 2022-05-03 at 09-16-20 Devices NetBox](https://user-images.githubusercontent.com/13487278/166459866-d209e138-ad06-45c5-aaea-9f8008d04595.png)
adam commented 2025-12-29 19:40:33 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (May 3, 2022):

@jeremystretch - It is the list shown when viewing a device role.

URL: /dcim/device-roles/<ID>/

image

Other examples would be /dcim/platforms/<ID>/

@kkthxbye-code commented on GitHub (May 3, 2022): @jeremystretch - It is the list shown when viewing a device role. URL: `/dcim/device-roles/<ID>/` ![image](https://user-images.githubusercontent.com/400797/166464783-af73b8a1-2705-434b-affd-63168d99b1ec.png) Other examples would be `/dcim/platforms/<ID>/`
adam commented 2025-12-29 19:40:33 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 4, 2022):

This is the same table as displayed in the devices list: Any preferences assigned to that table will be applied to this view as well. Does that address your use case?

@jeremystretch commented on GitHub (May 4, 2022): This is the same table as displayed in the devices list: Any preferences assigned to that table will be applied to this view as well. Does that address your use case?
adam commented 2025-12-29 19:40:33 +01:00
Author
Owner
Copy Link

@LHBL2003 commented on GitHub (May 4, 2022):

Thx @kkthxbye-code,

@jeremystretch

If you click on "Patch Panel" in the Role column, you will see that you cannot display comments.

we write general information about the panel in the comments. This tells us which area the panels are for. We don't need to see the panel's connectors first.

So you have to search for Patch Panel in the Device List to see the additional columns.

However, this is not as user-friendly and fast as with roles.

@LHBL2003 commented on GitHub (May 4, 2022): Thx @kkthxbye-code, @jeremystretch If you click on "Patch Panel" in the Role column, you will see that you cannot display comments. we write general information about the panel in the comments. This tells us which area the panels are for. We don't need to see the panel's connectors first. So you have to search for Patch Panel in the Device List to see the additional columns. However, this is not as user-friendly and fast as with roles.
adam commented 2025-12-29 19:40:33 +01:00
Author
Owner
Copy Link

@LHBL2003 commented on GitHub (May 4, 2022):

This is the same table as displayed in the devices list: Any preferences assigned to that table will be applied to this view as well. Does that address your use case?

Yes, I would be happy if the same columns are displayed in this view as I have set in the device list.

@LHBL2003 commented on GitHub (May 4, 2022): > This is the same table as displayed in the devices list: Any preferences assigned to that table will be applied to this view as well. Does that address your use case? Yes, I would be happy if the same columns are displayed in this view as I have set in the device list.
adam commented 2025-12-29 19:40:34 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 4, 2022):

If you click on "Patch Panel" in the Role column, you will see that you cannot display comments.

Ok, I see the issue. The table under the DeviceRole view is not being initialized with the current user, so the user's preferences are not being applied.

Looking into this further, the ideal approach would probably be to refactor NetBoxTable to apply user preferences under its configure() method, obviating the need to pass the user explicitly during instantiation of the table. However, this would be a breaking API change for plugins; it would need to wait for a minor release. In the interim, we can just pass the user where needed under the relevant views.

@jeremystretch commented on GitHub (May 4, 2022): > If you click on "Patch Panel" in the Role column, you will see that you cannot display comments. Ok, I see the issue. The table under the DeviceRole view is not being initialized with the current user, so the user's preferences are not being applied. Looking into this further, the ideal approach would probably be to refactor NetBoxTable to apply user preferences under its `configure()` method, obviating the need to pass the user explicitly during instantiation of the table. However, this would be a breaking API change for plugins; it would need to wait for a minor release. In the interim, we can just pass the user where needed under the relevant views.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6422
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?