starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Custom Validators - Direct Class Reference is passing the validator incorrectly #6386

New Issue
Closed
opened 2025-12-29 19:40:06 +01:00 by adam · 0 comments
adam commented 2025-12-29 19:40:06 +01:00
Owner
Copy Link

Originally created by @kkthxbye-code on GitHub (Apr 21, 2022).

Originally assigned to: @kkthxbye-code on GitHub.

Change Type

Correction

Area

Other

Proposed Changes

The example for Direct Class Reference currently looks like this.

from my_validators import Validator1, Validator2, Validator3

CUSTOM_VALIDATORS = {
    'dcim.site': (
        Validator1,
        Validator2,
    ),
    'dcim.device': (
        Validator3,
    )
}

When passing the uninitialized class, the code initializes it with the instance, which causes an error. It errors because it passes the instance to the constructor, which only expects a validation_rules dict.

d22f9000d6/netbox/extras/validators.py (L62-L64)

Suggested change:

from my_validators import Validator1, Validator2, Validator3

CUSTOM_VALIDATORS = {
    'dcim.site': (
        Validator1(),
        Validator2(),
    ),
    'dcim.device': (
        Validator3(),
    )
}
Originally created by @kkthxbye-code on GitHub (Apr 21, 2022). Originally assigned to: @kkthxbye-code on GitHub. ### Change Type Correction ### Area Other ### Proposed Changes The example for Direct Class Reference currently looks like this. ``` from my_validators import Validator1, Validator2, Validator3 CUSTOM_VALIDATORS = { 'dcim.site': ( Validator1, Validator2, ), 'dcim.device': ( Validator3, ) } ``` When passing the uninitialized class, the code initializes it with the instance, which causes an error. It errors because it passes the instance to the constructor, which only expects a `validation_rules` dict. https://github.com/netbox-community/netbox/blob/d22f9000d6ee103da81de5d8221ca4418be54a3a/netbox/extras/validators.py#L62-L64 Suggested change: ``` from my_validators import Validator1, Validator2, Validator3 CUSTOM_VALIDATORS = { 'dcim.site': ( Validator1(), Validator2(), ), 'dcim.device': ( Validator3(), ) } ```
adam added the status: acceptedtype: documentation labels 2025-12-29 19:40:06 +01:00
adam closed this issue 2025-12-29 19:40:06 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: documentation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6386
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?