starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Site selection in Prefix creation dialog does not limit VLAN group selection #6234

New Issue
Closed
opened 2025-12-29 19:38:20 +01:00 by adam · 2 comments
adam commented 2025-12-29 19:38:20 +01:00
Owner
Copy Link

Originally created by @stephanblanke on GitHub (Mar 19, 2022).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.1.10-dev

Python version

3.9

Steps to Reproduce

  1. Open the prefix creation form
  2. Under "Site/VLAN Assignment" select a site from the list
  3. Open selection menu for VLAN Group

Expected Behavior

Selecting a site from the list should limit the available VLAN Groups, that can be selected from the list.

Observed Behavior

Selecting a site from the list has no impact on the list of available VLAN Groups.

Originally created by @stephanblanke on GitHub (Mar 19, 2022). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.1.10-dev ### Python version 3.9 ### Steps to Reproduce 1. Open the prefix creation form 2. Under "Site/VLAN Assignment" select a site from the list 3. Open selection menu for VLAN Group ### Expected Behavior Selecting a site from the list should limit the available VLAN Groups, that can be selected from the list. ### Observed Behavior Selecting a site from the list has no impact on the list of available VLAN Groups.
adam added the type: bugstatus: accepted labels 2025-12-29 19:38:20 +01:00
adam closed this issue 2025-12-29 19:38:20 +01:00
adam commented 2025-12-29 19:38:21 +01:00
Author
Owner
Copy Link

@stephanblanke commented on GitHub (Mar 19, 2022):

I think the bug is here:
f64987d0c4/netbox/ipam/forms/models.py (L219-L230)

Changing site_id to scope_id (line 225) and ading scope_type = 'dcim.site' (before line 226) would work, but in that case VLAN groups that are not assigned to a specific site would not be displayed anymore. I am unsure, if that would be the desired behaviour.

@stephanblanke commented on GitHub (Mar 19, 2022): I think the bug is here: https://github.com/netbox-community/netbox/blob/f64987d0c4ddef473f997bfa71c8bca3d6adbf09/netbox/ipam/forms/models.py#L219-L230 Changing `site_id` to `scope_id` (line 225) and ading `scope_type = 'dcim.site'` (before line 226) would work, but in that case VLAN groups that are not assigned to a specific site would not be displayed anymore. I am unsure, if that would be the desired behaviour.
adam commented 2025-12-29 19:38:22 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Mar 22, 2022):

Close; site_id should be site. Thanks for the report!

@jeremystretch commented on GitHub (Mar 22, 2022): Close; `site_id` should be `site`. Thanks for the report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6234
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?