starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Update requirements.txt for social-auth-core to use 'all' extras #6028

New Issue
Closed
opened 2025-12-29 19:35:51 +01:00 by adam · 2 comments
adam commented 2025-12-29 19:35:51 +01:00
Owner
Copy Link

Originally created by @adamweiss on GitHub (Jan 31, 2022).

NetBox version

v3.1.6

Feature type

Change to existing functionality

Proposed functionality

In order to support OIDC and SAML in social-auth-core, requirements.txt would just need to be updated with "all" extras:

social-auth-core[all]==4.1.0

This is in base_requirements.txt, but it didn't make its way over to requirements.txt.

Use case

OIDC and SAML-based SSO

Database changes

N/A

External dependencies

Change social-auth-core to social-auth-core[all] in requirements

Originally created by @adamweiss on GitHub (Jan 31, 2022). ### NetBox version v3.1.6 ### Feature type Change to existing functionality ### Proposed functionality In order to support OIDC and SAML in social-auth-core, requirements.txt would just need to be updated with "all" extras: social-auth-core[all]==4.1.0 This is in base_requirements.txt, but it didn't make its way over to requirements.txt. ### Use case OIDC and SAML-based SSO ### Database changes N/A ### External dependencies Change social-auth-core to social-auth-core[all] in requirements
adam added the status: under reviewtype: housekeeping labels 2025-12-29 19:35:52 +01:00
adam closed this issue 2025-12-29 19:35:52 +01:00
adam commented 2025-12-29 19:35:52 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 1, 2022):

I'm not sure we want to direct people to install these ancillary packages by default if they're not necessarily going to be used. Users always have the option of installing these in addition to the default packages.

@jeremystretch commented on GitHub (Feb 1, 2022): I'm not sure we want to direct people to install these ancillary packages by default if they're not necessarily going to be used. Users always have the option of installing these in addition to the default packages.
adam commented 2025-12-29 19:35:52 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 3, 2022):

Per the discussion in #8503, we're just going to drop [all] from the base requirement listing for social-auth-core due to installation issues with a dependent system library. Users can of course install additional components manually, or override this requirement in local_requirements.txt within their own installation.

@jeremystretch commented on GitHub (Feb 3, 2022): Per the discussion in #8503, we're just going to drop `[all]` from the base requirement listing for `social-auth-core` due to installation issues with a dependent system library. Users can of course install additional components manually, or override this requirement in `local_requirements.txt` within their own installation.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: under review type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#6028
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?