starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 14:23:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Display description of fhrp group on fhrp selection #5990

New Issue
Closed
opened 2025-12-29 19:35:24 +01:00 by adam · 7 comments
adam commented 2025-12-29 19:35:24 +01:00
Owner
Copy Link

Originally created by @jlebherz on GitHub (Jan 23, 2022).

NetBox version

v3.1.6

Feature type

Change to existing functionality

Proposed functionality

display the description of a fhrp group on selection fields

Use case

better identify fhrp groups instead of only ID

image

Database changes

No response

External dependencies

No response

Originally created by @jlebherz on GitHub (Jan 23, 2022). ### NetBox version v3.1.6 ### Feature type Change to existing functionality ### Proposed functionality display the description of a fhrp group on selection fields ### Use case better identify fhrp groups instead of only ID ![image](https://user-images.githubusercontent.com/20497503/150698666-fe65f66c-c06c-43ed-8f0c-63aa1236775d.png) ### Database changes _No response_ ### External dependencies _No response_
adam added the type: featurepending closurestatus: under review labels 2025-12-29 19:35:24 +01:00
adam closed this issue 2025-12-29 19:35:24 +01:00
adam commented 2025-12-29 19:35:25 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 24, 2022):

The selection list shows the value of each object's display attribute returned by the REST API. As it would be inappropriate to include the description field in this value, this would require substantially changing how the dynamic selection field population works, which doesn't seem like a good use of developer effort right now.

@jeremystretch commented on GitHub (Jan 24, 2022): The selection list shows the value of each object's `display` attribute returned by the REST API. As it would be inappropriate to include the description field in this value, this would require substantially changing how the dynamic selection field population works, which doesn't seem like a good use of developer effort right now.
adam commented 2025-12-29 19:35:25 +01:00
Author
Owner
Copy Link

@fabricat commented on GitHub (Jan 27, 2022):

The current select list only shows FHRP type and ID (I am ignoring the assigned IP since in some cases we have lots of assigned IPs... and we cannot choose the "primary" one).
For APIs that could be enough, but from a human point of view, such a list is really hard to use.

Personally, I find it difficult to remember FHRP IDs, even because I had to set fake IDs on many groups.
We use Meraki and we have no visibility of IDs (actually, I am also trying to guess the underlying FHRP protocol).

@fabricat commented on GitHub (Jan 27, 2022): The current select list only shows FHRP type and ID (I am ignoring the assigned IP since in some cases we have lots of assigned IPs... and we cannot choose the "primary" one). For APIs that could be enough, but from a _human_ point of view, such a list is really hard to use. Personally, I find it difficult to remember FHRP IDs, even because I had to set _fake_ IDs on many groups. We use Meraki and we have no visibility of IDs (actually, I am also trying to guess the underlying FHRP protocol).
adam commented 2025-12-29 19:35:26 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Jun 6, 2022):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Jun 6, 2022): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 19:35:26 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Jul 6, 2022):

This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.

@github-actions[bot] commented on GitHub (Jul 6, 2022): This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.
adam commented 2025-12-29 19:35:26 +01:00
Author
Owner
Copy Link

@jcoeder commented on GitHub (Jul 7, 2022):

Can this be reopened and assigned to myself. It seem the original reporter and contributor lost interest or forgot about this. I would like to implement and get a PR out for it. Thanks!

@jcoeder commented on GitHub (Jul 7, 2022): Can this be reopened and assigned to myself. It seem the original reporter and contributor lost interest or forgot about this. I would like to implement and get a PR out for it. Thanks!
adam commented 2025-12-29 19:35:27 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jul 7, 2022):

@jcoeder per my comment above, there doesn't seem to be a feasible way to implement this without undertaking a considerable amount of work on the UI. What did you have in mind?

@jeremystretch commented on GitHub (Jul 7, 2022): @jcoeder per my comment [above](https://github.com/netbox-community/netbox/issues/8439#issuecomment-1020509770), there doesn't seem to be a feasible way to implement this without undertaking a considerable amount of work on the UI. What did you have in mind?
adam commented 2025-12-29 19:35:27 +01:00
Author
Owner
Copy Link

@jcoeder commented on GitHub (Jul 9, 2022):

Thanks! Sorry I am a little ignorant when it comes to Django and the layout of this project but the commit that was originally proposed seems to work just fine. Though I cannot say if this may cause issues somewhere else or if it would require additional code. I deployed this locally on at 3.2.5 instance and haven't noticed any issues after a couple days of hard use.

64dea8a780

Instead of this.

image

It ends up looking like this.

image

@jcoeder commented on GitHub (Jul 9, 2022): Thanks! Sorry I am a little ignorant when it comes to Django and the layout of this project but the commit that was originally proposed seems to work just fine. Though I cannot say if this may cause issues somewhere else or if it would require additional code. I deployed this locally on at 3.2.5 instance and haven't noticed any issues after a couple days of hard use. https://github.com/netbox-community/netbox/pull/8440/commits/64dea8a780f96382ea2f19752df322c4b3de2e45 Instead of this. ![image](https://user-images.githubusercontent.com/18300326/178090705-0ecd679f-8f21-4fb4-b1dc-96de9319913c.png) It ends up looking like this. ![image](https://user-images.githubusercontent.com/18300326/178090719-7ff7943d-a861-4a34-b725-3ec91a67a688.png)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pending closure status: under review type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5990
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?