starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Custom validation should use pre_save signal #5974

New Issue
Closed
opened 2025-12-29 19:35:04 +01:00 by adam · 1 comment
adam commented 2025-12-29 19:35:04 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Jan 20, 2022).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Connect the run_custom_validators() receiver to the Django's built-in pre_save signal instead of our custom post_clean signal.

Justification

This simplifies the custom validation process a bit, and ensures that custom validators are run only after the entire clean() method has completed.

Originally created by @jeremystretch on GitHub (Jan 20, 2022). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Connect the `run_custom_validators()` receiver to the Django's built-in `pre_save` signal instead of our custom `post_clean` signal. ### Justification This simplifies the custom validation process a bit, and ensures that custom validators are run only after the entire `clean()` method has completed.
adam added the type: housekeeping label 2025-12-29 19:35:04 +01:00
adam closed this issue 2025-12-29 19:35:04 +01:00
adam commented 2025-12-29 19:35:05 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 20, 2022):

I recall now why we didn't do this originally: We can't cleanly capture a validation error after pre_save has fired.

@jeremystretch commented on GitHub (Jan 20, 2022): I recall now why we didn't do this originally: We can't cleanly capture a validation error after `pre_save` has fired.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5974
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?