starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Devices > Edit: (get() returned more than one Manufacturer) when using multi custom permissions by tags #5943

New Issue
Closed
opened 2025-12-29 19:34:32 +01:00 by adam · 5 comments
adam commented 2025-12-29 19:34:32 +01:00
Owner
Copy Link

Originally created by @atom-tr on GitHub (Jan 14, 2022).

NetBox version

v3.1.5

Python version

3.8

Steps to Reproduce

I want to grant users or groups permissions to view and manage some objects by using tag. When I use a non-Superuser, I will see multiple result with each permission.
Below is an issue when it's happen.

  1. I create 2 permissions for all models have tags with:
  • [{"tags__name": "READABLE"}]: for all user can be view
  • [{"tags__name": "TECH"}]: for only technician can be create and edit.
  1. Technicians will be have both of 2 permissions above
  2. I creat a Manufacturer with 2 tags (READABLE & TECH). One for everyone can see, One for technician can edit and add to devices (I use admin account)
  3. I login to an technician account and create or edit a Device with this Manufacturer

  • I create a device with this Manufacturer => False
    Error

  • I edit a device with this Manufacturer => False
    Error

Expected Behavior

I can add multiple permissions for an object. For a group can edit their own objects and share to everyone with tag READABLE

Observed Behavior

If you use non-admin account, An objects have multiple permissions will return multi results (It's just 1 objeect) for each tag (permission).
In above case, It's raise error because Manufacturer which have Device Type I chosen have 2 tags. And each tags is belong to each custom permission.

Originally created by @atom-tr on GitHub (Jan 14, 2022). ### NetBox version v3.1.5 ### Python version 3.8 ### Steps to Reproduce I want to grant users or groups permissions to view and manage some objects by using tag. When I use a non-Superuser, I will see multiple result with each permission. Below is an issue when it's happen. 1. I create 2 permissions for all models have tags with: - `[{"tags__name": "READABLE"}]`: for all user can be view - `[{"tags__name": "TECH"}]`: for only technician can be create and edit. 2. Technicians will be have both of 2 permissions above 3. I creat a Manufacturer with 2 tags (READABLE & TECH). One for everyone can see, One for technician can edit and add to devices (I use admin account) 4. I login to an technician account and create or edit a Device with this Manufacturer - I create a device with this Manufacturer => False ![Error](https://i.imgur.com/GaNRLAm.png) - I edit a device with this Manufacturer => False ![Error](https://i.imgur.com/7vLWRiL.png) ### Expected Behavior I can add multiple permissions for an object. For a group can edit their own objects and share to everyone with tag READABLE ### Observed Behavior If you use non-admin account, An objects have multiple permissions will return multi results (It's just 1 objeect) for each tag (permission). In above case, It's raise error because Manufacturer which have Device Type I chosen have 2 tags. And each tags is belong to each custom permission.
adam added the type: bugstatus: revisions needed labels 2025-12-29 19:34:32 +01:00
adam closed this issue 2025-12-29 19:34:32 +01:00
adam commented 2025-12-29 19:34:33 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 14, 2022):

Hi, could you please revise your post above to be more clear about what objects you're creating? You mention permissions but don't say to which type(s) of object they're assigned. You also mention manufacturers but are creating/editing devices.

@jeremystretch commented on GitHub (Jan 14, 2022): Hi, could you please revise your post above to be more clear about what objects you're creating? You mention permissions but don't say to which type(s) of object they're assigned. You also mention manufacturers but are creating/editing devices.
adam commented 2025-12-29 19:34:33 +01:00
Author
Owner
Copy Link

@atom-tr commented on GitHub (Jan 15, 2022):

Hi, could you please revise your post above to be more clear about what objects you're creating? You mention permissions but don't say to which type(s) of object they're assigned. You also mention manufacturers but are creating/editing devices.

I create permissions base on Tags, so i create a permission for all object have tags. When i create a Device with a manufacturer, netbox return 2 manufacturers with each tag and each permission, which is only one if I login by admin account.

@atom-tr commented on GitHub (Jan 15, 2022): > Hi, could you please revise your post above to be more clear about what objects you're creating? You mention permissions but don't say to which type(s) of object they're assigned. You also mention manufacturers but are creating/editing devices. I create permissions base on Tags, so i create a permission for all object have tags. When i create a Device with a manufacturer, netbox return 2 manufacturers with each tag and each permission, which is only one if I login by admin account.
adam commented 2025-12-29 19:34:34 +01:00
Author
Owner
Copy Link

@atom-tr commented on GitHub (Jan 15, 2022):

Of course I can split permisson for some models that everyone can use. Not use tags. Its will fix the problem.

@atom-tr commented on GitHub (Jan 15, 2022): Of course I can split permisson for some models that everyone can use. Not use tags. Its will fix the problem.
adam commented 2025-12-29 19:34:34 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 17, 2022):

Please go back and rewrite your original post above to clearly indicate the steps someone else can take to reproduce the reported problem.

@jeremystretch commented on GitHub (Jan 17, 2022): Please go back and rewrite your original post above to clearly indicate the steps someone else can take to reproduce the reported problem.
adam commented 2025-12-29 19:34:34 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 1, 2022):

Closing this as sufficient reproduction instructions have not been provided.

@jeremystretch commented on GitHub (Feb 1, 2022): Closing this as sufficient reproduction instructions have not been provided.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: revisions needed type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5943
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?