starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Delete modal doesn't work on some pages #5914

New Issue
Closed
opened 2025-12-29 19:34:11 +01:00 by adam · 2 comments
adam commented 2025-12-29 19:34:11 +01:00
Owner
Copy Link

Originally created by @kkthxbye-code on GitHub (Jan 10, 2022).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.1.6-dev

Python version

3.9

Steps to Reproduce

  1. Create a device
  2. Create interface
  3. View device under the interface tab
  4. Press delete

Expected Behavior

Delete modal pops up

Observed Behavior

Nothing happens.

Cause: #8231

The reason is that some tabs already define the modal block in their template:

f1472d218e/netbox/templates/dcim/device/interfaces.html (L82-L84)

Changing it to:

{% block modals %}
  {% include 'inc/htmx_modal.html' %}
  {% table_config_form table %}
{% endblock modals %}

fixes the issue. When the tabs templates define the modal, they don't get the default modal defined in generic/object.html

This is an issue in all templates that overwrite the modals block and use the htmx modal.

Examples:

  • dcim/device/interfaces.html
  • dcim/device/frontports.html
  • dcim/device/rearports.html
  • dcim/device/consoleports.html

etc.

Originally created by @kkthxbye-code on GitHub (Jan 10, 2022). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.1.6-dev ### Python version 3.9 ### Steps to Reproduce 1. Create a device 2. Create interface 3. View device under the interface tab 4. Press delete ### Expected Behavior Delete modal pops up ### Observed Behavior Nothing happens. Cause: #8231 The reason is that some tabs already define the modal block in their template: https://github.com/netbox-community/netbox/blob/f1472d218e157160306e7007fb3a705208901a71/netbox/templates/dcim/device/interfaces.html#L82-L84 Changing it to: ```python {% block modals %} {% include 'inc/htmx_modal.html' %} {% table_config_form table %} {% endblock modals %} ``` fixes the issue. When the tabs templates define the modal, they don't get the default modal defined in `generic/object.html` This is an issue in all templates that overwrite the modals block and use the htmx modal. Examples: * `dcim/device/interfaces.html` * `dcim/device/frontports.html` * `dcim/device/rearports.html` * `dcim/device/consoleports.html` etc.
adam added the type: bugstatus: accepted labels 2025-12-29 19:34:11 +01:00
adam closed this issue 2025-12-29 19:34:11 +01:00
adam commented 2025-12-29 19:34:12 +01:00
Author
Owner
Copy Link

@kkthxbye-code commented on GitHub (Jan 10, 2022):

I guess you could actually just add {{ block.super }} to all the offending blocks. Not really sure what is best practice.

@kkthxbye-code commented on GitHub (Jan 10, 2022): I guess you could actually just add `{{ block.super }}` to all the offending blocks. Not really sure what is best practice.
adam commented 2025-12-29 19:34:12 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 10, 2022):

Yep, {{ block.super }} is the way to go. Good catch.

@jeremystretch commented on GitHub (Jan 10, 2022): Yep, `{{ block.super }}` is the way to go. Good catch.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5914
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?