starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Allow ChoiceVar() to have optional setting #5877

New Issue
Closed
opened 2025-12-29 19:33:44 +01:00 by adam · 1 comment
adam commented 2025-12-29 19:33:44 +01:00
Owner
Copy Link

Originally created by @candlerb on GitHub (Jan 4, 2022).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.1.4

Feature type

Change to existing functionality

Proposed functionality

When you set required=False on a ChoiceVar, have no choice selected by default, and allow the user not to select anything.

Currently, if you have e.g.

cable_color = ChoiceVar(choices=ColorChoices.CHOICES, required=False, label="Cable Color")

then there is an arbitrary color chosen by default, and the user is required to select one.

Use case

For using built-in choices like CableTypeChoices.CHOICES or ColorChoices.CHOICES where no choice is a valid selection.

Workaround:

NO_CHOICE = (
        ('', '---------'),
)

cable_color = ChoiceVar(choices=NO_CHOICE+ColorChoices.CHOICES, required=False, label="Cable Color")

(Note however that required=False is still required)

Database changes

None

External dependencies

None

Originally created by @candlerb on GitHub (Jan 4, 2022). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.1.4 ### Feature type Change to existing functionality ### Proposed functionality When you set `required=False` on a ChoiceVar, have no choice selected by default, and allow the user not to select anything. Currently, if you have e.g. ``` cable_color = ChoiceVar(choices=ColorChoices.CHOICES, required=False, label="Cable Color") ``` then there is an arbitrary color chosen by default, and the user is required to select one. ### Use case For using built-in choices like `CableTypeChoices.CHOICES` or `ColorChoices.CHOICES` where no choice is a valid selection. Workaround: ``` NO_CHOICE = ( ('', '---------'), ) cable_color = ChoiceVar(choices=NO_CHOICE+ColorChoices.CHOICES, required=False, label="Cable Color") ``` (Note however that `required=False` *is* still required) ### Database changes None ### External dependencies None
adam added the type: bugstatus: accepted labels 2025-12-29 19:33:44 +01:00
adam closed this issue 2025-12-29 19:33:44 +01:00
adam commented 2025-12-29 19:33:45 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 5, 2022):

Reclassifying this as a bug.

@jeremystretch commented on GitHub (Jan 5, 2022): Reclassifying this as a bug.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5877
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?