starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Leverage HTMX for confirmation dialogs #5875

New Issue
Closed
opened 2025-12-29 19:33:44 +01:00 by adam · 0 comments
adam commented 2025-12-29 19:33:44 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Jan 5, 2022).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.1.4

Feature type

Change to existing functionality

Proposed functionality

Currently, when deleting an object, two requests are made:

  1. The user clicks delete and is taken to the deletion confirmation form.
  2. The user submits the confirmation form, the object is deleted, and the user is redirected to the return URL.

It should be trivial to instead use a modal dialog to display the confirmation form. The proposed workflow would be:

  1. The user clicks delete and an HTMX request is made to retrieve the confirmation form (and any relevant information, such as related objects). The form is rendered in a modal and displayed, but the user remains on the original page.
  2. The user submits the confirmation form, the object is deleted, and the user is redirected to the return URL.

Although we're still technically making two requests, the first loads only the confirmation form and avoids a complete page request.

We should be able to implement this entirely within the relevant generic view classes.

Use case

Loading the confirmation dialog via HTMX avoids a full page refresh and greatly reduces the time needed to delete an object (and especially to abort the deletion of an object).

Database changes

No response

External dependencies

No response

Originally created by @jeremystretch on GitHub (Jan 5, 2022). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.1.4 ### Feature type Change to existing functionality ### Proposed functionality Currently, when deleting an object, two requests are made: 1. The user clicks delete and is taken to the deletion confirmation form. 2. The user submits the confirmation form, the object is deleted, and the user is redirected to the return URL. It should be trivial to instead use a modal dialog to display the confirmation form. The proposed workflow would be: 1. The user clicks delete and an HTMX request is made to retrieve the confirmation form (and any relevant information, such as related objects). The form is rendered in a modal and displayed, but the user remains on the original page. 2. The user submits the confirmation form, the object is deleted, and the user is redirected to the return URL. Although we're still technically making two requests, the first loads only the confirmation form and avoids a complete page request. We should be able to implement this entirely within the relevant generic view classes. ### Use case Loading the confirmation dialog via HTMX avoids a full page refresh and greatly reduces the time needed to delete an object (and especially to abort the deletion of an object). ### Database changes _No response_ ### External dependencies _No response_
adam added the status: acceptedtype: feature labels 2025-12-29 19:33:44 +01:00
adam closed this issue 2025-12-29 19:33:44 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5875
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?