starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

FHRP group address doesn't honor unique space #5745

New Issue
Closed
opened 2025-12-29 19:32:07 +01:00 by adam · 4 comments
adam commented 2025-12-29 19:32:07 +01:00
Owner
Copy Link

Originally created by @zombah on GitHub (Dec 8, 2021).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.1.0

Python version

3.8

Steps to Reproduce

  1. Create vrf UniqueSpaceVRF and enable Unique space in it
  2. Create IP address 192.168.1.1/24 inside vrf UniqueSpaceVRF
  3. Create FHRP group with id 100, vrf UniqueSpaceVRF and address 192.168.1.1/24

Expected Behavior

Error that vrf is unique space

Observed Behavior

FHRP group creates duplicate ip inside unique space vrf

Originally created by @zombah on GitHub (Dec 8, 2021). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.1.0 ### Python version 3.8 ### Steps to Reproduce 1. Create vrf UniqueSpaceVRF and enable Unique space in it 2. Create IP address 192.168.1.1/24 inside vrf UniqueSpaceVRF 3. Create FHRP group with id 100, vrf UniqueSpaceVRF and address 192.168.1.1/24 ### Expected Behavior Error that vrf is unique space ### Observed Behavior FHRP group creates duplicate ip inside unique space vrf
adam added the type: bugstatus: accepted labels 2025-12-29 19:32:07 +01:00
adam closed this issue 2025-12-29 19:32:07 +01:00
adam commented 2025-12-29 19:32:07 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Dec 8, 2021):

This is because the address role for certain roles is exempt from consideration for uniqueness. I believe Anycast, VIP, VRRP, HSRP, GLBP are all exempt from uniqueness constraints.

I am not sure if this is documented anywhere however.

@DanSheps commented on GitHub (Dec 8, 2021): This is because the address role for certain roles is exempt from consideration for uniqueness. I believe Anycast, VIP, VRRP, HSRP, GLBP are all exempt from uniqueness constraints. I am not sure if this is documented anywhere however.
adam commented 2025-12-29 19:32:08 +01:00
Author
Owner
Copy Link

@zombah commented on GitHub (Dec 8, 2021):

Oh but this is not working if i'm trying to create this address 192.168.1.1/24 with role VIP manualy, receive error on create that duplicate not allowed.
But works if original ip created without roles changed to VIP or VRRP.

@zombah commented on GitHub (Dec 8, 2021): Oh but this is not working if i'm trying to create this address 192.168.1.1/24 with role VIP manualy, receive error on create that duplicate not allowed. But works if original ip created without roles changed to VIP or VRRP.
adam commented 2025-12-29 19:32:08 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Dec 8, 2021):

We likely bypass the check, at least that is my guess.

We could add the check, however I am not sure how desireable that is.

@DanSheps commented on GitHub (Dec 8, 2021): We likely bypass the check, at least that is my guess. We could add the check, however I am not sure how desireable that is.
adam commented 2025-12-29 19:32:08 +01:00
Author
Owner
Copy Link

@zombah commented on GitHub (Dec 9, 2021):

Imo some check may help as there is no clear create ip or assing ip like inside interfaces and will result in orphaned duplicates in unique ip space.

@zombah commented on GitHub (Dec 9, 2021): Imo some check may help as there is no clear create ip or assing ip like inside interfaces and will result in orphaned duplicates in unique ip space.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5745
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?