starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Use another augmented assignment statement #5642

New Issue
Closed
opened 2025-12-29 19:30:35 +01:00 by adam · 1 comment
adam commented 2025-12-29 19:30:35 +01:00
Owner
Copy Link

Originally created by @elfring on GitHub (Nov 10, 2021).

NetBox version

v3.0.9

Feature type

Change to existing functionality

Proposed functionality

👀 Some source code analysis tools can help to find opportunities for improving software components.
💭 I propose to increase the usage of augmented assignment statements accordingly.

diff --git a/netbox/netbox/authentication.py b/netbox/netbox/authentication.py
index 653fad3b0..14a4bcbb7 100644
--- a/netbox/netbox/authentication.py
+++ b/netbox/netbox/authentication.py
@@ -260,7 +260,7 @@ try:
             if (self.settings.FIND_GROUP_PERMS and
                     hasattr(user_obj, "ldap_user") and
                     hasattr(user_obj.ldap_user, "group_names")):
-                permission_filter = permission_filter | Q(groups__name__in=user_obj.ldap_user.group_names)
+                permission_filter |= Q(groups__name__in=user_obj.ldap_user.group_names)
             return permission_filter
 except ModuleNotFoundError:
     pass

Use case

Rationale of the Python enhancement proposal 203 (from 2000-07-13)

Database changes

No response

External dependencies

No response

Originally created by @elfring on GitHub (Nov 10, 2021). ### NetBox version v3.0.9 ### Feature type Change to existing functionality ### Proposed functionality :eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly. ```diff diff --git a/netbox/netbox/authentication.py b/netbox/netbox/authentication.py index 653fad3b0..14a4bcbb7 100644 --- a/netbox/netbox/authentication.py +++ b/netbox/netbox/authentication.py @@ -260,7 +260,7 @@ try: if (self.settings.FIND_GROUP_PERMS and hasattr(user_obj, "ldap_user") and hasattr(user_obj.ldap_user, "group_names")): - permission_filter = permission_filter | Q(groups__name__in=user_obj.ldap_user.group_names) + permission_filter |= Q(groups__name__in=user_obj.ldap_user.group_names) return permission_filter except ModuleNotFoundError: pass ``` ### Use case [Rationale of the Python enhancement proposal 203](https://www.python.org/dev/peps/pep-0203/#rationale "Proposal for augmented assignments") (from 2000-07-13) ### Database changes _No response_ ### External dependencies _No response_
adam closed this issue 2025-12-29 19:30:35 +01:00
adam commented 2025-12-29 19:30:36 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Nov 10, 2021):

Thank you for your interest in NetBox. I'm afraid we're not accepting feature requests for minor housekeeping items. As this does not appear to effect any substantial change to NetBox's operation, this issue is being closed.

If you'd like to contribute to NetBox's development, there are plenty issues in need of an owner to consider. Thanks!

@jeremystretch commented on GitHub (Nov 10, 2021): Thank you for your interest in NetBox. I'm afraid we're not accepting feature requests for minor housekeeping items. As this does not appear to effect any substantial change to NetBox's operation, this issue is being closed. If you'd like to contribute to NetBox's development, there are plenty [issues in need of an owner](https://github.com/netbox-community/netbox/issues?q=is%3Aissue+is%3Aopen+label%3A%22status%3A+needs+owner%22) to consider. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5642
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?