starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Incorrect import CSV with multiline values #5632

New Issue
Closed
opened 2025-12-29 19:30:20 +01:00 by adam · 2 comments
adam commented 2025-12-29 19:30:20 +01:00
Owner
Copy Link

Originally created by @seros1521 on GitHub (Nov 9, 2021).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.0.8

Python version

3.7

Steps to Reproduce

1.open the CSV file import page for Sites
2.import a CSV file with the following content:

name,slug,status,comments
name1,slug1,active,"multiline
comment"

Expected Behavior

The "comments" field is expected to preserve the line break.

Observed Behavior

When importing a file, the line break in the multi-line comments field disappears.
When importing through the "CSV Data" form, the import is correct, the line feed is preserved.

Originally created by @seros1521 on GitHub (Nov 9, 2021). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.0.8 ### Python version 3.7 ### Steps to Reproduce 1.open the CSV file import page for Sites 2.import a CSV file with the following content: ``` name,slug,status,comments name1,slug1,active,"multiline comment" ``` ### Expected Behavior The "comments" field is expected to preserve the line break. ### Observed Behavior When importing a file, the line break in the multi-line comments field disappears. When importing through the "CSV Data" form, the import is correct, the line feed is preserved.
adam added the type: bugstatus: accepted labels 2025-12-29 19:30:20 +01:00
adam closed this issue 2025-12-29 19:30:20 +01:00
adam commented 2025-12-29 19:30:20 +01:00
Author
Owner
Copy Link

@seros1521 commented on GitHub (Nov 9, 2021):

Different behavior occurs due to different way of processing input data:
26ceeb61ef/netbox/utilities/forms/fields.py (L190)
and
26ceeb61ef/netbox/utilities/forms/fields.py (L227)

Demo:

>>> import csv
>>> from io import StringIO
>>> s="""name,slug,status,comments
... name1,slug1,active,"multiline
... comment"
... """
>>> 
>>> [i for i in s.splitlines()]
['name,slug,status,comments', 'name1,slug1,active,"multiline', 'comment"']
>>> 
>>> [i for i in StringIO(s)]
['name,slug,status,comments\n', 'name1,slug1,active,"multiline\n', 'comment"\n']
>>> 
>>> [i for i in csv.reader(s.splitlines())]
[['name', 'slug', 'status', 'comments'], ['name1', 'slug1', 'active', 'multilinecomment']]
>>> 
>>> [i for i in csv.reader(StringIO(s))]
[['name', 'slug', 'status', 'comments'], ['name1', 'slug1', 'active', 'multiline\ncomment']]
>>>
@seros1521 commented on GitHub (Nov 9, 2021): Different behavior occurs due to different way of processing input data: https://github.com/netbox-community/netbox/blob/26ceeb61ef9bca7d348caa71b7353a279f70c775/netbox/utilities/forms/fields.py#L190 and https://github.com/netbox-community/netbox/blob/26ceeb61ef9bca7d348caa71b7353a279f70c775/netbox/utilities/forms/fields.py#L227 Demo: ``` >>> import csv >>> from io import StringIO >>> s="""name,slug,status,comments ... name1,slug1,active,"multiline ... comment" ... """ >>> >>> [i for i in s.splitlines()] ['name,slug,status,comments', 'name1,slug1,active,"multiline', 'comment"'] >>> >>> [i for i in StringIO(s)] ['name,slug,status,comments\n', 'name1,slug1,active,"multiline\n', 'comment"\n'] >>> >>> [i for i in csv.reader(s.splitlines())] [['name', 'slug', 'status', 'comments'], ['name1', 'slug1', 'active', 'multilinecomment']] >>> >>> [i for i in csv.reader(StringIO(s))] [['name', 'slug', 'status', 'comments'], ['name1', 'slug1', 'active', 'multiline\ncomment']] >>> ```
adam commented 2025-12-29 19:30:21 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Nov 9, 2021):

Can you comment your test cases?

To clarify, StringIO is the desired import right?

When importing a file, the line break in the multi-line comments field disappears.
When importing through the "CSV Data" form, the import is correct, the line feed is preserved.

Could you also clarify this? What is the case for each?

@DanSheps commented on GitHub (Nov 9, 2021): Can you comment your test cases? To clarify, StringIO is the desired import right? > When importing a file, the line break in the multi-line comments field disappears. > When importing through the "CSV Data" form, the import is correct, the line feed is preserved. Could you also clarify this? What is the case for each?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5632
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?