starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Web pagination broken when MAX_PAGE_SIZE = 0 #5596

New Issue
Closed
opened 2025-12-29 19:29:57 +01:00 by adam · 2 comments
adam commented 2025-12-29 19:29:57 +01:00
Owner
Copy Link

Originally created by @jhammond-git on GitHub (Nov 3, 2021).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.0.8

Python version

3.8

Steps to Reproduce

  1. Set MAX_PAGE_SIZE to 0 in configuration.py. If necessary, restart Netbox services.
  2. Log into Netbox.
  3. Go to any table that supports pagination.
  4. Change your page size from the default.
  5. Browse to a different table that supports pagination.

Expected Behavior

Your pages should be the same size that you changed them to in step 4.

Observed Behavior

Page size is switched back to default. When checking user preferences, the pagination.per_page setting is updated correctly, but not honored.

Originally created by @jhammond-git on GitHub (Nov 3, 2021). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.0.8 ### Python version 3.8 ### Steps to Reproduce 1. Set MAX_PAGE_SIZE to 0 in configuration.py. If necessary, restart Netbox services. 2. Log into Netbox. 3. Go to any table that supports pagination. 4. Change your page size from the default. 5. Browse to a different table that supports pagination. ### Expected Behavior Your pages should be the same size that you changed them to in step 4. ### Observed Behavior Page size is switched back to default. When checking user preferences, the pagination.per_page setting is updated correctly, but not honored.
adam added the type: bugstatus: accepted labels 2025-12-29 19:29:57 +01:00
adam closed this issue 2025-12-29 19:29:57 +01:00
adam commented 2025-12-29 19:29:58 +01:00
Author
Owner
Copy Link

@jhammond-git commented on GitHub (Nov 3, 2021):

I'm not sure if I'm following the logic correctly, but this is how I read it.

The function get_paginate_count is called. That function, among other things, returns the smallest of per_page or PAGINATE_COUNT and MAX_PAGE_SIZE.

The example I was looking at then created an EnhancedPaginator object which would set the per_page attribute to that returned value, or if 0, set per_page to PAGINATE_COUNT (which in my environment is the default of 50).

I must be missing something because all our pages were set at 25 when MAX_PAGE_SIZE was 0.

@jhammond-git commented on GitHub (Nov 3, 2021): I'm not sure if I'm following the logic correctly, but this is how I read it. The function get_paginate_count is called. That function, among other things, returns the smallest of per_page or PAGINATE_COUNT and MAX_PAGE_SIZE. The example I was looking at then created an EnhancedPaginator object which would set the per_page attribute to that returned value, or if 0, set per_page to PAGINATE_COUNT (which in my environment is the default of 50). I must be missing something because all our pages were set at 25 when MAX_PAGE_SIZE was 0.
adam commented 2025-12-29 19:29:58 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Nov 3, 2021):

The problem was in the get_paginate_count() function, which was returning min(per_page, settings.MAX_PAGE_SIZE) without regard to whether MAX_PAGE_SIZE was non-zero. Thanks for the report!

@jeremystretch commented on GitHub (Nov 3, 2021): The problem was in the `get_paginate_count()` function, which was returning `min(per_page, settings.MAX_PAGE_SIZE)` without regard to whether `MAX_PAGE_SIZE` was non-zero. Thanks for the report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5596
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?