starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Standardize the usage of field_groups for FilterForms #5584

New Issue
Closed
opened 2025-12-29 19:29:47 +01:00 by adam · 0 comments
adam commented 2025-12-29 19:29:47 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Oct 29, 2021).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

NetBox v3.0 introduced support for specifying a list-of-lists to inform the order and grouping of fields with filter forms. For example:

class ProviderFilterForm(BootstrapMixin, CustomFieldModelFilterForm):
    model = Provider
    field_groups = [
        ['q', 'tag'],
        ['region_id', 'site_group_id', 'site_id'],
    ]

We need to do a sweep to ensure that these are all defined consistently, and that field_order is no longer used.

Justification

Consistency & cleanup

Originally created by @jeremystretch on GitHub (Oct 29, 2021). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes NetBox v3.0 introduced support for specifying a list-of-lists to inform the order and grouping of fields with filter forms. For example: ``` class ProviderFilterForm(BootstrapMixin, CustomFieldModelFilterForm): model = Provider field_groups = [ ['q', 'tag'], ['region_id', 'site_group_id', 'site_id'], ] ``` We need to do a sweep to ensure that these are all defined consistently, and that `field_order` is no longer used. ### Justification Consistency & cleanup
adam added the status: acceptedtype: housekeeping labels 2025-12-29 19:29:47 +01:00
adam closed this issue 2025-12-29 19:29:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5584
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?