starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Can't affect UI theme preference #5544

New Issue
Closed
opened 2025-12-29 19:29:14 +01:00 by adam · 4 comments
adam commented 2025-12-29 19:29:14 +01:00
Owner
Copy Link

Originally created by @Ren60FHk on GitHub (Oct 21, 2021).

Originally assigned to: @thatmattlove on GitHub.

NetBox version

3.0.8

Python version

3.7

Steps to Reproduce

  1. Set the light theme in Profile & Settings.
  2. Save changes.
  3. Logout.
  4. Clear a browser cache.
  5. Log in.

Expected Behavior

I expect to see the light theme.

Observed Behavior

The theme is dark.

Originally created by @Ren60FHk on GitHub (Oct 21, 2021). Originally assigned to: @thatmattlove on GitHub. ### NetBox version 3.0.8 ### Python version 3.7 ### Steps to Reproduce 1. Set the light theme in **Profile & Settings**. 2. Save changes. 3. Logout. 4. Clear a browser cache. 5. Log in. ### Expected Behavior I expect to see the light theme. ### Observed Behavior The theme is dark.
adam added the type: bugstatus: accepted labels 2025-12-29 19:29:14 +01:00
adam closed this issue 2025-12-29 19:29:15 +01:00
adam commented 2025-12-29 19:29:15 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 21, 2021):

I'm not able to replicate this in v3.0.8. Do you have your browser configured to prefer dark mode? Maybe try a different browser?

@jeremystretch commented on GitHub (Oct 21, 2021): I'm not able to replicate this in v3.0.8. Do you have your browser configured to prefer dark mode? Maybe try a different browser?
adam commented 2025-12-29 19:29:15 +01:00
Author
Owner
Copy Link

@Ren60FHk commented on GitHub (Oct 21, 2021):

I've tried another browser before posting - same result. But, I've changed a browser internal theme from dark to light and NetBox had replicated that behaviour. Thus, NetBox leans on the browser (maybe even system for someone) color theme.

@Ren60FHk commented on GitHub (Oct 21, 2021): I've tried another browser before posting - same result. But, I've changed a browser internal theme from dark to light and NetBox had replicated that behaviour. Thus, NetBox leans on the browser (maybe even system for someone) color theme.
adam commented 2025-12-29 19:29:16 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 27, 2021):

I'm not really sure which should take precedence. @thatmattlove any thoughts?

@jeremystretch commented on GitHub (Oct 27, 2021): I'm not really sure which should take precedence. @thatmattlove any thoughts?
adam commented 2025-12-29 19:29:16 +01:00
Author
Owner
Copy Link

@thatmattlove commented on GitHub (Oct 27, 2021):

Tricky one. Hopefully a090955 adequately resolves this. The challenge is we have multiple vectors from which to determine the color mode:

  1. System/browser preference (prefers-color-scheme media query) — should be considered the lowest priority, since it's inferred and not explicit. ('system mode' below)
  2. Mode set by UI toggles (not system preference) — should be considered temporary, not persisted to the user's profile, and not persisted across browser sessions. ('client mode' below)
  3. Mode set by system preference — should be persisted in the user's profile and therefore across any of that user's browser sessions. ('server mode' below)

Seems simple on the face, but consider the scenarios:

  • System mode is set through inference, client mode is not set, server mode is not set
  • System mode is set through inference, client mode is set, server mode is not set — which to use?
  • System mode is set through inference, client mode is set, server mode is set, client mode and server mode do not match — which to use?
  • System mode is set through inference, client mode is not set, server mode is set

And, consider that these "problems" are presented on each page load and any time a color mode toggle is used.

Ultimately, I implemented the logic as:

  1. If the mode was inferred and the server mode is set, use the server mode, overriding the inferred mode.
  2. If the client mode is not set and the server mode is, use the server mode, overriding the inferred mode.
  3. If the client mode is set and the server mode is not set, use the client mode, but allow it to be overridden if/when a server mode is set (for example, after login).
  4. If the client mode is set, and the server mode is set, and they are not the same, use the client mode. This is an assumption on my part that the client mode is more recently set via a toggle.
  5. Otherwise, use the inferred mode from the system/browser.
  6. As a last resort in the event of an error or no matching conditions whatsoever, use light mode.
@thatmattlove commented on GitHub (Oct 27, 2021): Tricky one. Hopefully a090955 adequately resolves this. The challenge is we have multiple vectors from which to determine the color mode: 1. System/browser preference (`prefers-color-scheme` media query) — should be considered the lowest priority, since it's inferred and not explicit. (*'system mode' below*) 2. Mode set by UI toggles (not system preference) — should be considered temporary, not persisted to the user's profile, and not persisted across browser sessions. (*'client mode' below*) 3. Mode set by system preference — should be persisted in the user's profile and therefore across any of that user's browser sessions. (*'server mode' below*) Seems simple on the face, but consider the scenarios: - System mode is set through inference, client mode is not set, server mode is not set - System mode is set through inference, client mode is set, server mode is not set — which to use? - System mode is set through inference, client mode is set, server mode is set, client mode and server mode do not match — which to use? - System mode is set through inference, client mode is not set, server mode is set And, consider that these "problems" are presented on each page load and any time a color mode toggle is used. Ultimately, I implemented the logic as: 1. If the mode was inferred and the server mode is set, use the server mode, overriding the inferred mode. 2. If the client mode is not set and the server mode is, use the server mode, overriding the inferred mode. 3. If the client mode is set and the server mode is not set, use the client mode, but allow it to be overridden if/when a server mode is set (for example, after login). 4. If the client mode is set, and the server mode is set, and they are not the same, use the client mode. This is an assumption on my part that the client mode is more recently set via a toggle. 5. Otherwise, use the inferred mode from the system/browser. 6. As a last resort in the event of an error or no matching conditions whatsoever, use light mode.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5544
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?