starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Rename optic type 128gfc-sfp28 to 128gfc-qsfp28 (Fibrechannel) #5538

New Issue
Closed
opened 2025-12-29 19:29:07 +01:00 by adam · 1 comment
adam commented 2025-12-29 19:29:07 +01:00
Owner
Copy Link

Originally created by @suom1 on GitHub (Oct 20, 2021).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v3.0.7

Python version

3.8

Steps to Reproduce

Currently the 128G FC optic type is named 128gfc-sfp28, which is wrong as it's not a SFP28 formfactor but a QSFP28.

Expected Behavior

The optic type should be 128gfc-qsfp28 to be correct with the type of optic it is.

Observed Behavior

Problem was noticed when working on netbox-community/devicetype-library#503.

Originally created by @suom1 on GitHub (Oct 20, 2021). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v3.0.7 ### Python version 3.8 ### Steps to Reproduce Currently the 128G FC optic type is named `128gfc-sfp28`, which is wrong as it's not a SFP28 formfactor but a QSFP28. ### Expected Behavior The optic type should be `128gfc-qsfp28` to be correct with the type of optic it is. ### Observed Behavior Problem was noticed when working on [netbox-community/devicetype-library#503](https://github.com/netbox-community/devicetype-library/pull/503).
adam added the type: bugstatus: accepted labels 2025-12-29 19:29:07 +01:00
adam closed this issue 2025-12-29 19:29:07 +01:00
adam commented 2025-12-29 19:29:07 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Nov 17, 2021):

I'm going to bump this to v3.1.0 since the corrected value effects a breaking change.

@jeremystretch commented on GitHub (Nov 17, 2021): I'm going to bump this to v3.1.0 since the corrected value effects a breaking change.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5538
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?