starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

NewVersion showing url #5524

New Issue
Closed
opened 2025-12-29 19:28:59 +01:00 by adam · 6 comments
adam commented 2025-12-29 19:28:59 +01:00
Owner
Copy Link

Originally created by @PieterL75 on GitHub (Oct 18, 2021).

Originally assigned to: @PieterL75 on GitHub.

NetBox version

v3.0.7

Python version

3.7

Steps to Reproduce

When a new release is available, Netbox wil inform the admins about it.

Fix :
1f4263aa6d/netbox/netbox/views/init.py#L140
replace that with
'version': str(release_verion),

Expected Behavior

A nice view with the new version number, with an hyperlink to the release on github
good

Observed Behavior

The version is shown with the url, but containing the git url as text, rather than an hyperlink
bad

Originally created by @PieterL75 on GitHub (Oct 18, 2021). Originally assigned to: @PieterL75 on GitHub. ### NetBox version v3.0.7 ### Python version 3.7 ### Steps to Reproduce When a new release is available, Netbox wil inform the admins about it. Fix : https://github.com/netbox-community/netbox/blob/1f4263aa6d7c4f054f1ccd6fd2249f8314dfa3c7/netbox/netbox/views/__init__.py#L140 replace that with 'version': str(release_verion), ### Expected Behavior A nice view with the new version number, with an hyperlink to the release on github ![good](https://user-images.githubusercontent.com/74899468/137447665-15be7a52-ed5c-441d-948e-c849ee3496ea.png) ### Observed Behavior The version is shown with the url, but containing the git url as text, rather than an hyperlink ![bad](https://user-images.githubusercontent.com/74899468/137447560-09d445fb-ef1d-4065-8cfc-9bbfa65678a7.png)
adam added the type: bugstatus: accepted labels 2025-12-29 19:28:59 +01:00
adam closed this issue 2025-12-29 19:29:00 +01:00
adam commented 2025-12-29 19:29:00 +01:00
Author
Owner
Copy Link

@apellini commented on GitHub (Oct 18, 2021):

If I use following regex:
import re
re.search("([0-9].[0-9].[0-9])", str(latest_release)).string

Could it help to solve?

Regards,

Aldo Pellini

@apellini commented on GitHub (Oct 18, 2021): If I use following regex: import re re.search("([0-9].[0-9].[0-9])", str(latest_release)).string Could it help to solve? Regards, Aldo Pellini
adam commented 2025-12-29 19:29:00 +01:00
Author
Owner
Copy Link

@PieterL75 commented on GitHub (Oct 18, 2021):

The fix is mentioned in the bug..

Fix :
9c6938e7ae/netbox/netbox/views/init.py#L140

replace that with
'version': str(release_verion),

but I gave it a shot and created a pull request https://github.com/netbox-community/netbox/pull/7566

@PieterL75 commented on GitHub (Oct 18, 2021): The fix is mentioned in the bug.. Fix : https://github.com/netbox-community/netbox/blob/9c6938e7ae8e85d83d34f1b4b10145b4f629bc86/netbox/netbox/views/__init__.py#L140 replace that with 'version': str(release_verion), but I gave it a shot and created a pull request https://github.com/netbox-community/netbox/pull/7566
adam commented 2025-12-29 19:29:01 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Oct 18, 2021):

Pieter, please make sure you also update the changelog (although if you are uncomfortable doing it when can take care of this on merge)

@DanSheps commented on GitHub (Oct 18, 2021): Pieter, please make sure you also update the changelog (although if you are uncomfortable doing it when can take care of this on merge)
adam commented 2025-12-29 19:29:01 +01:00
Author
Owner
Copy Link

@PieterL75 commented on GitHub (Oct 19, 2021):

Still need to figure out Pull Requests .. I now have two... Sorry about that...

@PieterL75 commented on GitHub (Oct 19, 2021): Still need to figure out Pull Requests .. I now have two... Sorry about that...
adam commented 2025-12-29 19:29:01 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Oct 19, 2021):

You just add a new commit to the branch you were working on to add the existing commit.

@DanSheps commented on GitHub (Oct 19, 2021): You just add a new commit to the branch you were working on to add the existing commit.
adam commented 2025-12-29 19:29:01 +01:00
Author
Owner
Copy Link

@PieterL75 commented on GitHub (Oct 19, 2021):

Daniel,

I updated the existing PR with the release notes update..

Sorry for the work you have me, it was probably easier to do it yourself..
But on the other hand, ty for guiding me to get this done..
It will be helpful when I see other small quick-fix things that you
dont have to be bothered with

Pieter

Op di 19 okt. 2021 om 15:45 schreef Daniel Sheppard <
@.***>:

You just add a new commit to the branch you were working on to add the
existing commit.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/netbox-community/netbox/issues/7556#issuecomment-946740273,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR3OADGWMXDJUSKK65RMAY3UHVZAVANCNFSM5GF3GFLQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@PieterL75 commented on GitHub (Oct 19, 2021): Daniel, I updated the existing PR with the release notes update.. Sorry for the work you have me, it was probably easier to do it yourself.. But on the other hand, ty for guiding me to get this done.. It will be helpful when I see other small quick-fix things that you dont have to be bothered with Pieter Op di 19 okt. 2021 om 15:45 schreef Daniel Sheppard < ***@***.***>: > You just add a new commit to the branch you were working on to add the > existing commit. > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > <https://github.com/netbox-community/netbox/issues/7556#issuecomment-946740273>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AR3OADGWMXDJUSKK65RMAY3UHVZAVANCNFSM5GF3GFLQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > >
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5524
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?