starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Incorrect row colors in LLDP Neighbors tab #5390

New Issue
Closed
opened 2025-12-29 19:27:24 +01:00 by adam · 0 comments
adam commented 2025-12-29 19:27:24 +01:00
Owner
Copy Link

Originally created by @pwlodawi on GitHub (Sep 18, 2021).

Originally assigned to: @thatmattlove on GitHub.

NetBox version

v3.0.2

Python version

3.8

Steps to Reproduce

  1. Configure devices/interfaces similar to shown below
  2. Open LLDP Neighbors tab
    Screenshot from 2021-09-18 13-27-56

Expected Behavior

First row is given "danger" class because configured interface name doesn't match LLDP interface name.

Observed Behavior

First row gets "success" class despite interface names don't match.

I see two issues here:

  1. When interface has label configured column "Configured Interface" has format "name (label)" which never matches interface name from LLDP. Shouldn' t label part be removed before comparing to LLDP data ?
  2. Interface comparison in line 54 never takes effect because of comparison in line 57. Effectively, "danger" class is used only if device names don't match. I'm not sure if it intended behavior. If so, what is interface comparison in line 54 for ?
    27c0e6dd5e/netbox/project-static/src/device/lldp.ts (L50-L61).
Originally created by @pwlodawi on GitHub (Sep 18, 2021). Originally assigned to: @thatmattlove on GitHub. ### NetBox version v3.0.2 ### Python version 3.8 ### Steps to Reproduce 1. Configure devices/interfaces similar to shown below 2. Open LLDP Neighbors tab ![Screenshot from 2021-09-18 13-27-56](https://user-images.githubusercontent.com/49796436/133887862-883c3c24-f718-477d-b2f0-bcf9307d8485.png) ### Expected Behavior First row is given "danger" class because configured interface name doesn't match LLDP interface name. ### Observed Behavior First row gets "success" class despite interface names don't match. I see two issues here: 1. When interface has label configured column "Configured Interface" has format "name (label)" which never matches interface name from LLDP. Shouldn' t label part be removed before comparing to LLDP data ? 2. Interface comparison in line 54 never takes effect because of comparison in line 57. Effectively, "danger" class is used only if device names don't match. I'm not sure if it intended behavior. If so, what is interface comparison in line 54 for ? https://github.com/netbox-community/netbox/blob/27c0e6dd5e8732483533dbf3d4333a81fe9e7948/netbox/project-static/src/device/lldp.ts#L50-L61.
adam added the type: bugstatus: accepted labels 2025-12-29 19:27:25 +01:00
adam closed this issue 2025-12-29 19:27:25 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5390
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?