mirror of
https://github.com/netbox-community/netbox.git
synced 2026-01-11 21:10:29 +01:00
Modifying a Device Type doesn't update existing devices? #533
Closed
opened 2025-12-29 16:22:57 +01:00 by adam
·
12 comments
No Branch/Tag Specified
main
update-changelog-comments-docs
feature-removal-issue-type
20911-dropdown
20239-plugin-menu-classes-mutable-state
21097-graphql-id-lookups
feature
fix_module_substitution
20923-dcim-templates
20044-elevation-stuck-lightmode
feature-ip-prefix-link
v4.5-beta1-release
20068-import-moduletype-attrs
20766-fix-german-translation-code-literals
20378-del-script
7604-filter-modifiers-v3
circuit-swap
12318-case-insensitive-uniqueness
20637-improve-device-q-filter
20660-script-load
19724-graphql
20614-update-ruff
14884-script
02496-max-page
19720-macaddress-interface-generic-relation
19408-circuit-terminations-export-templates
20203-openapi-check
fix-19669-api-image-download
7604-filter-modifiers
19275-fixes-interface-bulk-edit
fix-17794-get_field_value_return_list
11507-show-aggregate-and-rir-on-api
9583-add_column_specific_search_field_to_tables
v4.5.0
v4.4.10
v4.4.9
v4.5.0-beta1
v4.4.8
v4.4.7
v4.4.6
v4.4.5
v4.4.4
v4.4.3
v4.4.2
v4.4.1
v4.4.0
v4.3.7
v4.4.0-beta1
v4.3.6
v4.3.5
v4.3.4
v4.3.3
v4.3.2
v4.3.1
v4.3.0
v4.2.9
v4.3.0-beta2
v4.2.8
v4.3.0-beta1
v4.2.7
v4.2.6
v4.2.5
v4.2.4
v4.2.3
v4.2.2
v4.2.1
v4.2.0
v4.1.11
v4.1.10
v4.1.9
v4.1.8
v4.2-beta1
v4.1.7
v4.1.6
v4.1.5
v4.1.4
v4.1.3
v4.1.2
v4.1.1
v4.1.0
v4.0.11
v4.0.10
v4.0.9
v4.1-beta1
v4.0.8
v4.0.7
v4.0.6
v4.0.5
v4.0.3
v4.0.2
v4.0.1
v4.0.0
v3.7.8
v3.7.7
v4.0-beta2
v3.7.6
v3.7.5
v4.0-beta1
v3.7.4
v3.7.3
v3.7.2
v3.7.1
v3.7.0
v3.6.9
v3.6.8
v3.6.7
v3.7-beta1
v3.6.6
v3.6.5
v3.6.4
v3.6.3
v3.6.2
v3.6.1
v3.6.0
v3.5.9
v3.6-beta2
v3.5.8
v3.6-beta1
v3.5.7
v3.5.6
v3.5.5
v3.5.4
v3.5.3
v3.5.2
v3.5.1
v3.5.0
v3.4.10
v3.4.9
v3.5-beta2
v3.4.8
v3.5-beta1
v3.4.7
v3.4.6
v3.4.5
v3.4.4
v3.4.3
v3.4.2
v3.4.1
v3.4.0
v3.3.10
v3.3.9
v3.4-beta1
v3.3.8
v3.3.7
v3.3.6
v3.3.5
v3.3.4
v3.3.3
v3.3.2
v3.3.1
v3.3.0
v3.2.9
v3.2.8
v3.3-beta2
v3.2.7
v3.3-beta1
v3.2.6
v3.2.5
v3.2.4
v3.2.3
v3.2.2
v3.2.1
v3.2.0
v3.1.11
v3.1.10
v3.2-beta2
v3.1.9
v3.2-beta1
v3.1.8
v3.1.7
v3.1.6
v3.1.5
v3.1.4
v3.1.3
v3.1.2
v3.1.1
v3.1.0
v3.0.12
v3.0.11
v3.0.10
v3.1-beta1
v3.0.9
v3.0.8
v3.0.7
v3.0.6
v3.0.5
v3.0.4
v3.0.3
v3.0.2
v3.0.1
v3.0.0
v2.11.12
v3.0-beta2
v2.11.11
v2.11.10
v3.0-beta1
v2.11.9
v2.11.8
v2.11.7
v2.11.6
v2.11.5
v2.11.4
v2.11.3
v2.11.2
v2.11.1
v2.11.0
v2.10.10
v2.10.9
v2.11-beta1
v2.10.8
v2.10.7
v2.10.6
v2.10.5
v2.10.4
v2.10.3
v2.10.2
v2.10.1
v2.10.0
v2.9.11
v2.10-beta2
v2.9.10
v2.10-beta1
v2.9.9
v2.9.8
v2.9.7
v2.9.6
v2.9.5
v2.9.4
v2.9.3
v2.9.2
v2.9.1
v2.9.0
v2.9-beta2
v2.8.9
v2.9-beta1
v2.8.8
v2.8.7
v2.8.6
v2.8.5
v2.8.4
v2.8.3
v2.8.2
v2.8.1
v2.8.0
v2.7.12
v2.7.11
v2.7.10
v2.7.9
v2.7.8
v2.7.7
v2.7.6
v2.7.5
v2.7.4
v2.7.3
v2.7.2
v2.7.1
v2.7.0
v2.6.12
v2.6.11
v2.6.10
v2.6.9
v2.7-beta1
Solcon-2020-01-06
v2.6.8
v2.6.7
v2.6.6
v2.6.5
v2.6.4
v2.6.3
v2.6.2
v2.6.1
v2.6.0
v2.5.13
v2.5.12
v2.6-beta1
v2.5.11
v2.5.10
v2.5.9
v2.5.8
v2.5.7
v2.5.6
v2.5.5
v2.5.4
v2.5.3
v2.5.2
v2.5.1
v2.5.0
v2.4.9
v2.5-beta2
v2.4.8
v2.5-beta1
v2.4.7
v2.4.6
v2.4.5
v2.4.4
v2.4.3
v2.4.2
v2.4.1
v2.4.0
v2.3.7
v2.4-beta1
v2.3.6
v2.3.5
v2.3.4
v2.3.3
v2.3.2
v2.3.1
v2.3.0
v2.2.10
v2.3-beta2
v2.2.9
v2.3-beta1
v2.2.8
v2.2.7
v2.2.6
v2.2.5
v2.2.4
v2.2.3
v2.2.2
v2.2.1
v2.2.0
v2.1.6
v2.2-beta2
v2.1.5
v2.2-beta1
v2.1.4
v2.1.3
v2.1.2
v2.1.1
v2.1.0
v2.0.10
v2.1-beta1
v2.0.9
v2.0.8
v2.0.7
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v2.0.0
v2.0-beta3
v1.9.6
v1.9.5
v2.0-beta2
v1.9.4-r1
v1.9.3
v2.0-beta1
v1.9.2
v1.9.1
v1.9.0-r1
v1.8.4
v1.8.3
v1.8.2
v1.8.1
v1.8.0
v1.7.3
v1.7.2-r1
v1.7.1
v1.7.0
v1.6.3
v1.6.2-r1
v1.6.1-r1
1.6.1
v1.6.0
v1.5.2
v1.5.1
v1.5.0
v1.4.2
v1.4.1
v1.4.0
v1.3.2
v1.3.1
v1.3.0
v1.2.2
v1.2.1
v1.2.0
v1.1.0
v1.0.7-r1
v1.0.7
v1.0.6
v1.0.5
v1.0.4
v1.0.3-r1
v1.0.3
1.0.0
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/netbox#533
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @roblarose on GitHub (Nov 11, 2016).
We realized after creating several PDUs that they did not have Power Ports, but we do want to be able to track which UPS they're fed from.
Adding a Power Port to the device type didn't show one on existing devices, though. We had to re-create all the PDUs.
Is there a way to update existing devices w/ changes to the underlying type?
@therealjoshuad commented on GitHub (Nov 11, 2016):
Editing a device type doesn't edit the devices, you should be able to go to the device itself, and add a power port there
@roblarose commented on GitHub (Nov 12, 2016):
Doesn't look like we were able to add power ports on our PDU device types.
rob larose | engineer | rock paper scissors | 212-255-6446 |
www.rockpaperscissors.com http://rockpaperscissors.com/
On Fri, Nov 11, 2016 at 5:57 PM, therealjoshuad notifications@github.com
wrote:
@therealjoshuad commented on GitHub (Nov 12, 2016):
Do you have the little plus signs near the connections? Or am I thinking of something different?

@roblarose commented on GitHub (Nov 12, 2016):
Nope. I create a new device type with "PDU" checked and then create a
device of that type, then when I look at "critical connections" on the
device, power port is not an option. Screenshots attached.
Other device types (non-PDU) allow me to add power ports.
[image: Inline image 3][image: Inline image 2][image: Inline image 1]
rob larose | engineer | rock paper scissors | 212-255-6446 |
www.rockpaperscissors.com http://rockpaperscissors.com/
On Fri, Nov 11, 2016 at 6:10 PM, therealjoshuad notifications@github.com
wrote:
@LBegnaud commented on GitHub (Nov 12, 2016):
when you specify something as a pdu, the interfaces are considered power ports
@roblarose commented on GitHub (Nov 12, 2016):
Which do you mean? Interfaces still seems to be NICs.
I can add Power Outlets to the a PDU device, but I can only add a power
port (under "Critical Connections") on the Device Type.
--Rob
rob larose | engineer | rock paper scissors | 212-255-6446 |
www.rockpaperscissors.com http://rockpaperscissors.com/
On Fri, Nov 11, 2016 at 6:29 PM, LBegnaud notifications@github.com wrote:
@LBegnaud commented on GitHub (Nov 12, 2016):
When you define the device type, you uncheck "this is a network device" I believe
@roblarose commented on GitHub (Nov 12, 2016):
Your screenshot shows outlets though, not plugs/ports.
We're doing UPS with outlets connected to PDU power ports/plugs, then the
PDU outlets connect to the device power ports/plugs.
--Rob
This message was composed
entirely with my right thumb.
Please excuse any typos.
On Nov 11, 2016, at 7:02 PM, LBegnaud notifications@github.com wrote:
[image: image]
https://cloud.githubusercontent.com/assets/15981748/20233768/ce08fcc2-a838-11e6-9a00-bf04e307fbd8.png
When you define the device type, you uncheck "this is a network device" I
believe
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/digitalocean/netbox/issues/687#issuecomment-260083696,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWUyk__bt0HuVnmc7qmAMmSv82acG92Dks5q9QH3gaJpZM4KwM1W
.
@jeremystretch commented on GitHub (Nov 14, 2016):
Modifying the components of a device type does not retroactively modify existing devices. This is an intentional limitation to avoid conflicts.
NetBox doesn't currently allow you to add power ports to a device which is classified as a PDU, because there's no way to model the power circuits that feed PDUs. This is sort of a place holder for when we incorporate structured power (see #54).
This raises a bug in that a PDU device type can be assigned power port templates. I've opened #691 to address this. For now, we simply don't model anything upstream of the PDU; again, #54 is open to extend the data model for this eventually.
@roblarose commented on GitHub (Nov 14, 2016):
Hi Jeremy,
I see -- you're saying the lack of power ports is intentional and the
fact that i can add one to the type itself is the bug? :-)
We recognize that you don't model the AC source circuits, but I imagine
in the majority of use cases, you have at least 2 PDU devices in line (UPS
-> PDU -> Device) so I'd argue in favor of ability to assign PDU power
ports for that reason regardless of the state of #54.
We're going ahead with our PDUs having power ports. If/when you decide
to fix that "bug," will we have trouble, or just not be able to do it
anymore going forward from there?
--Rob
rob larose | engineer | rock paper scissors | 212-255-6446 |
www.rockpaperscissors.com http://rockpaperscissors.com/
On Mon, Nov 14, 2016 at 10:53 AM, Jeremy Stretch notifications@github.com
wrote:
@jeremystretch commented on GitHub (Nov 14, 2016):
That's a fair point. NetBox was originally developed to represent data center environments in which power feeds external to each rack are delivered directly to PDUs. #691 will allow the assignment of power ports to PDUs; this will be available in v1.7.1.
Once we get around to #54, we'll likely model power feeds the way we do data circuits: a power port can be connected to either a power outlet (upstream device) or to a power circuit.
@roblarose commented on GitHub (Nov 14, 2016):
Sounds great. Thanks. :-)
We love the product, btw -- just the thing for a smallish server room setup
like ours.
--Rob
rob larose | engineer | rock paper scissors | 212-255-6446 |
www.rockpaperscissors.com http://rockpaperscissors.com/
On Mon, Nov 14, 2016 at 11:31 AM, Jeremy Stretch notifications@github.com
wrote: