starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Bulk edit of interfaces to add VLANs in VLAN group does not work #5291

New Issue
Closed
opened 2025-12-29 19:26:17 +01:00 by adam · 8 comments
adam commented 2025-12-29 19:26:17 +01:00
Owner
Copy Link

Originally created by @beatjoerg on GitHub (Sep 1, 2021).

NetBox version

V3.0.0.0

Python version

3.9

Steps to Reproduce

  1. Do a bulk edit and try to assign a VLAN that is part of a VLAN Group (and not associated to a site)
  2. The following API Call is done: /api/ipam/vlans/?brief=true&site_id=1, which does not select the VLAN in a VLAN group

Expected Behavior

VLANs belonging to a VLAN Group need to be shown too

Observed Behavior

VLANs in a VLAN Group not shown

Originally created by @beatjoerg on GitHub (Sep 1, 2021). ### NetBox version V3.0.0.0 ### Python version 3.9 ### Steps to Reproduce 1. Do a bulk edit and try to assign a VLAN that is part of a VLAN Group (and not associated to a site) 2. The following API Call is done: /api/ipam/vlans/?brief=true&site_id=1, which does not select the VLAN in a VLAN group ### Expected Behavior VLANs belonging to a VLAN Group need to be shown too ### Observed Behavior VLANs in a VLAN Group not shown
adam added the type: bug label 2025-12-29 19:26:17 +01:00
adam closed this issue 2025-12-29 19:26:17 +01:00
adam commented 2025-12-29 19:26:17 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Sep 1, 2021):

V3.0.0.0

Super secret special version?

Confirmed vlan groups is missing from Bulk edit in v3.0.1, however I believe this was present in v2.11.12 as well

@DanSheps commented on GitHub (Sep 1, 2021): > V3.0.0.0 Super secret special version? --- Confirmed vlan groups is missing from Bulk edit in v3.0.1, however I believe this was present in v2.11.12 as well
adam commented 2025-12-29 19:26:18 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Sep 1, 2021):

Matt, I can take a stab at this one if you don't have the time.

@DanSheps commented on GitHub (Sep 1, 2021): Matt, I can take a stab at this one if you don't have the time.
adam commented 2025-12-29 19:26:18 +01:00
Author
Owner
Copy Link

@thatmattlove commented on GitHub (Sep 2, 2021):

Maybe I'm not completely understanding the reproduction steps, but I'm not able to reproduce this on v3.0.1. It's also possible one of the fixes included in v3.0.1 inadvertently resolved this as well. Steps I've done:

  1. Add new VLAN Group (test-group)
  2. Add new VLAN (test-vlan)
  3. Add VLAN test-vlan to VLAN Group test-group
  4. Navigate to a device's interfaces tab, select two interfaces, click Edit Selected
  5. In untagged VLANs field, I am able to see VLAN test-vlan

@DanSheps - you mentioned VLAN Groups being missing from Bulk Edit, but on which view? I don't see why one would need the VLAN Group field while bulk editing a device's interface, but perhaps I'm missing something.

@thatmattlove commented on GitHub (Sep 2, 2021): Maybe I'm not completely understanding the reproduction steps, but I'm not able to reproduce this on v3.0.1. It's also possible one of the fixes included in v3.0.1 inadvertently resolved this as well. Steps I've done: 1. Add new VLAN Group (test-group) 2. Add new VLAN (test-vlan) 3. Add VLAN test-vlan to VLAN Group test-group 4. Navigate to a device's interfaces tab, select two interfaces, click Edit Selected 5. In untagged VLANs field, I am able to see VLAN test-vlan @DanSheps - you mentioned VLAN Groups being missing from Bulk Edit, but on which view? I don't see why one would need the VLAN Group field while bulk editing a device's interface, but perhaps I'm missing something.
adam commented 2025-12-29 19:26:18 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Sep 2, 2021):

On the main interfaces table, not from a device itself.

I will be honest, not sure of the best technical way to do this.

@DanSheps commented on GitHub (Sep 2, 2021): On the main interfaces table, not from a device itself. I will be honest, not sure of the best technical way to do this.
adam commented 2025-12-29 19:26:18 +01:00
Author
Owner
Copy Link

@thatmattlove commented on GitHub (Sep 2, 2021):

Ok, now I understand. I've also confirmed this is present in v2.11.

@thatmattlove commented on GitHub (Sep 2, 2021): Ok, now I understand. I've also confirmed this is present in v2.11.
adam commented 2025-12-29 19:26:19 +01:00
Author
Owner
Copy Link

@beatjoerg commented on GitHub (Sep 2, 2021):

Probably it is also related to #7124, as parameters for API calls survives requests.
I just tried it with the current dev version (8ede7a9297).
The API Call even from the interfaces tab generates wrong fiters if you do an edit first on device 1 and then on device 2. So the steps to reproduce will vary what you did before.

Just also noted that in bulk edit (form interface tab of a device) the UI selects automatically the first available VLAN, but that seems to be another story. (this is a regression of ddff193786, which selects on any dropdown without an empty option the first avaiable entry --> should I open an new bug?)

@beatjoerg commented on GitHub (Sep 2, 2021): Probably it is also related to #7124, as parameters for API calls survives requests. I just tried it with the current dev version (8ede7a9297c19c88d8c8481d2fc2aa3cdaf3c269). The API Call even from the interfaces tab generates wrong fiters if you do an edit first on device 1 and then on device 2. So the steps to reproduce will vary what you did before. Just also noted that in bulk edit (form interface tab of a device) the UI selects automatically the first available VLAN, but that seems to be another story. (this is a regression of ddff1937861ac47ba59efa4256e5301a7ce23902, which selects on any dropdown without an empty option the first avaiable entry --> should I open an new bug?)
adam commented 2025-12-29 19:26:19 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Sep 3, 2021):

I just tried it with the current dev version (8ede7a9).

This appears fixed in 3.0.1, if not, please re-open #7124

(this is a regression of ddff193, which selects on any dropdown without an empty option the first available entry --> should I open an new bug?)

If you can reproduce on the current 3.0.1, yes, please do, if there is an existing bug please link the bugs.

@DanSheps commented on GitHub (Sep 3, 2021): > I just tried it with the current dev version ([8ede7a9](https://github.com/netbox-community/netbox/commit/8ede7a9297c19c88d8c8481d2fc2aa3cdaf3c269)). This appears fixed in 3.0.1, if not, please re-open #7124 > (this is a regression of ddff193, which selects on any dropdown without an empty option the first available entry --> should I open an new bug?) If you can reproduce on the current 3.0.1, yes, please do, if there is an existing bug please link the bugs.
adam commented 2025-12-29 19:26:19 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 2, 2021):

Closing this out as it appears to have been resolved in a more recent release.

@jeremystretch commented on GitHub (Oct 2, 2021): Closing this out as it appears to have been resolved in a more recent release.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5291
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?