mirror of
https://github.com/netbox-community/netbox.git
synced 2026-01-11 21:10:29 +01:00
webhook on device deletion gets triggered in both update and delete #5181
Closed
opened 2025-12-29 19:25:09 +01:00 by adam
·
13 comments
No Branch/Tag Specified
main
update-changelog-comments-docs
feature-removal-issue-type
20911-dropdown
20239-plugin-menu-classes-mutable-state
21097-graphql-id-lookups
feature
fix_module_substitution
20923-dcim-templates
20044-elevation-stuck-lightmode
feature-ip-prefix-link
v4.5-beta1-release
20068-import-moduletype-attrs
20766-fix-german-translation-code-literals
20378-del-script
7604-filter-modifiers-v3
circuit-swap
12318-case-insensitive-uniqueness
20637-improve-device-q-filter
20660-script-load
19724-graphql
20614-update-ruff
14884-script
02496-max-page
19720-macaddress-interface-generic-relation
19408-circuit-terminations-export-templates
20203-openapi-check
fix-19669-api-image-download
7604-filter-modifiers
19275-fixes-interface-bulk-edit
fix-17794-get_field_value_return_list
11507-show-aggregate-and-rir-on-api
9583-add_column_specific_search_field_to_tables
v4.5.0
v4.4.10
v4.4.9
v4.5.0-beta1
v4.4.8
v4.4.7
v4.4.6
v4.4.5
v4.4.4
v4.4.3
v4.4.2
v4.4.1
v4.4.0
v4.3.7
v4.4.0-beta1
v4.3.6
v4.3.5
v4.3.4
v4.3.3
v4.3.2
v4.3.1
v4.3.0
v4.2.9
v4.3.0-beta2
v4.2.8
v4.3.0-beta1
v4.2.7
v4.2.6
v4.2.5
v4.2.4
v4.2.3
v4.2.2
v4.2.1
v4.2.0
v4.1.11
v4.1.10
v4.1.9
v4.1.8
v4.2-beta1
v4.1.7
v4.1.6
v4.1.5
v4.1.4
v4.1.3
v4.1.2
v4.1.1
v4.1.0
v4.0.11
v4.0.10
v4.0.9
v4.1-beta1
v4.0.8
v4.0.7
v4.0.6
v4.0.5
v4.0.3
v4.0.2
v4.0.1
v4.0.0
v3.7.8
v3.7.7
v4.0-beta2
v3.7.6
v3.7.5
v4.0-beta1
v3.7.4
v3.7.3
v3.7.2
v3.7.1
v3.7.0
v3.6.9
v3.6.8
v3.6.7
v3.7-beta1
v3.6.6
v3.6.5
v3.6.4
v3.6.3
v3.6.2
v3.6.1
v3.6.0
v3.5.9
v3.6-beta2
v3.5.8
v3.6-beta1
v3.5.7
v3.5.6
v3.5.5
v3.5.4
v3.5.3
v3.5.2
v3.5.1
v3.5.0
v3.4.10
v3.4.9
v3.5-beta2
v3.4.8
v3.5-beta1
v3.4.7
v3.4.6
v3.4.5
v3.4.4
v3.4.3
v3.4.2
v3.4.1
v3.4.0
v3.3.10
v3.3.9
v3.4-beta1
v3.3.8
v3.3.7
v3.3.6
v3.3.5
v3.3.4
v3.3.3
v3.3.2
v3.3.1
v3.3.0
v3.2.9
v3.2.8
v3.3-beta2
v3.2.7
v3.3-beta1
v3.2.6
v3.2.5
v3.2.4
v3.2.3
v3.2.2
v3.2.1
v3.2.0
v3.1.11
v3.1.10
v3.2-beta2
v3.1.9
v3.2-beta1
v3.1.8
v3.1.7
v3.1.6
v3.1.5
v3.1.4
v3.1.3
v3.1.2
v3.1.1
v3.1.0
v3.0.12
v3.0.11
v3.0.10
v3.1-beta1
v3.0.9
v3.0.8
v3.0.7
v3.0.6
v3.0.5
v3.0.4
v3.0.3
v3.0.2
v3.0.1
v3.0.0
v2.11.12
v3.0-beta2
v2.11.11
v2.11.10
v3.0-beta1
v2.11.9
v2.11.8
v2.11.7
v2.11.6
v2.11.5
v2.11.4
v2.11.3
v2.11.2
v2.11.1
v2.11.0
v2.10.10
v2.10.9
v2.11-beta1
v2.10.8
v2.10.7
v2.10.6
v2.10.5
v2.10.4
v2.10.3
v2.10.2
v2.10.1
v2.10.0
v2.9.11
v2.10-beta2
v2.9.10
v2.10-beta1
v2.9.9
v2.9.8
v2.9.7
v2.9.6
v2.9.5
v2.9.4
v2.9.3
v2.9.2
v2.9.1
v2.9.0
v2.9-beta2
v2.8.9
v2.9-beta1
v2.8.8
v2.8.7
v2.8.6
v2.8.5
v2.8.4
v2.8.3
v2.8.2
v2.8.1
v2.8.0
v2.7.12
v2.7.11
v2.7.10
v2.7.9
v2.7.8
v2.7.7
v2.7.6
v2.7.5
v2.7.4
v2.7.3
v2.7.2
v2.7.1
v2.7.0
v2.6.12
v2.6.11
v2.6.10
v2.6.9
v2.7-beta1
Solcon-2020-01-06
v2.6.8
v2.6.7
v2.6.6
v2.6.5
v2.6.4
v2.6.3
v2.6.2
v2.6.1
v2.6.0
v2.5.13
v2.5.12
v2.6-beta1
v2.5.11
v2.5.10
v2.5.9
v2.5.8
v2.5.7
v2.5.6
v2.5.5
v2.5.4
v2.5.3
v2.5.2
v2.5.1
v2.5.0
v2.4.9
v2.5-beta2
v2.4.8
v2.5-beta1
v2.4.7
v2.4.6
v2.4.5
v2.4.4
v2.4.3
v2.4.2
v2.4.1
v2.4.0
v2.3.7
v2.4-beta1
v2.3.6
v2.3.5
v2.3.4
v2.3.3
v2.3.2
v2.3.1
v2.3.0
v2.2.10
v2.3-beta2
v2.2.9
v2.3-beta1
v2.2.8
v2.2.7
v2.2.6
v2.2.5
v2.2.4
v2.2.3
v2.2.2
v2.2.1
v2.2.0
v2.1.6
v2.2-beta2
v2.1.5
v2.2-beta1
v2.1.4
v2.1.3
v2.1.2
v2.1.1
v2.1.0
v2.0.10
v2.1-beta1
v2.0.9
v2.0.8
v2.0.7
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v2.0.0
v2.0-beta3
v1.9.6
v1.9.5
v2.0-beta2
v1.9.4-r1
v1.9.3
v2.0-beta1
v1.9.2
v1.9.1
v1.9.0-r1
v1.8.4
v1.8.3
v1.8.2
v1.8.1
v1.8.0
v1.7.3
v1.7.2-r1
v1.7.1
v1.7.0
v1.6.3
v1.6.2-r1
v1.6.1-r1
1.6.1
v1.6.0
v1.5.2
v1.5.1
v1.5.0
v1.4.2
v1.4.1
v1.4.0
v1.3.2
v1.3.1
v1.3.0
v1.2.2
v1.2.1
v1.2.0
v1.1.0
v1.0.7-r1
v1.0.7
v1.0.6
v1.0.5
v1.0.4
v1.0.3-r1
v1.0.3
1.0.0
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
Mirrored from GitHub Pull Request
No Label
type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/netbox#5181
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ifoughal on GitHub (Aug 14, 2021).
NetBox version
v2.11.11
Python version
3.8.10
Steps to Reproduce
create a webhook on the admin pannel:
-webhook url:
after adding afforementionned webhooks and enabling them. I proceeded with my tests, using update / delete methods to trigger jenkins builds.
the update device webhook works as intended, so it triggers the build and everything works as intended.
however when the deletion method is used on a device, the delete webhook would trigger both webhooks, thus triggering both my jenkins pipelines, even though the pipelines are using completely different tokens, thus leading me to believe that the delete method on Netbox triggers both delete and update webhooks if they are configered on the same object.
The bug actually is visual I believe, because when the url for the webhook is exactly the same, I get the following message while trying to add the second webhook:
it seems to be a front end, of default value for the front end check boxes related issue, as when you try to create a webhook with the same url + token without sperate headers, even though the first is on delete and the second is on update, netbox doesn't allow that. but if you select create with any of the other options, then it works.
Expected Behavior
Upon deleting a device, I expected to trigger the deletion webhook only.
Observed Behavior
Impossible to create a delete and an update webhooks with the same url + headers, but possible with create + delete or create + update webhooks.
@jeremystretch commented on GitHub (Aug 16, 2021):
Please provide complete steps to reproduce the reported behavior, beginning with the creation of the webhook.
@ifoughal commented on GitHub (Aug 17, 2021):
I have provided more information by updating the issue.
TLDR;
The issue is related to how netbox interprets the default values for the update, create, delete checkboxes.
From my inderstanding, it's impossible to create an update and a delete webhook seperately, because netbox thinks they are duplicates as one or the other is always enabled, thus allowing create with any of the two options, but in reality one or maybe both of them are always enabled by default.
@jeremystretch commented on GitHub (Aug 23, 2021):
I'm sorry but you're trying to pack too much into a single bug report. Is the issue that you believe an update webhook is firing erroneously, or is that you're unable to create multiple webhooks in NetBox? Let's pick one thing and focus on that.
@ifoughal commented on GitHub (Aug 23, 2021):
The update webhook is indeed triggered erroneously when a delete action is on a device object.
I believe that the issue lays somewhere on the admin pannel front end, since it seems that netbox thinks that both webhooks (delete & update) already exist when I try to add a new webhook for the delete with the exact same url.
@ifoughal commented on GitHub (Sep 30, 2021):
After some thourough testing with Jenkins, I have finally figured it out.
During the deletion procedure of a device, exactly 2 update methods get applied on the device itself.
My guess is, some backend scripts trigger these updates during probably the deletion of the primary addresses, and other cascading deletions similar to this.
The solution here would be to work on the deletion method, so that it doesn't trigger any other webhooks, as this breaks automation processes relying on webhooks (eg: deleting a node from netbox triggers a deletion on the monitoring service, but would also trigger an update pipeline at the same time, due to how the deletion process works currently.)
@ifoughal commented on GitHub (Nov 15, 2021):
I'm closing this ticket, as it seems that it has been partially solved on the beta version with issue #6238
@kevinsdirectory commented on GitHub (Nov 16, 2021):
@idrisFoughali I have the same problem, how did you prevent from triggering webhook update when deleting a device.
@ifoughal commented on GitHub (Nov 16, 2021):
Sadly I never did, so far I have not managed to implement a deletion webhook for objects that have cascading deletions with updates in between (such as management interface and its ip addresses getting deleted during a device deletion process, which then updates the devices while deleting it, thus triggering a false positive)
With the new webhook implementation, this might maybe get resolved, I guess we'll have to wait and see, but it seems that the netbox devs are not that interested in fixing this.
Edit: Reopened the issue.
@jeremystretch commented on GitHub (Nov 17, 2021):
That or we've been busy triaging ~150 issues per month from the thousands of other people who use NetBox and this one bug report, which hasn't had a single other user comment until 17 hours ago, hasn't been a priority. If you'd like to own this and propose a solution I'll gladly assign it to you.
@ifoughal commented on GitHub (Nov 17, 2021):
Apologies, it really was not in my intentions to downplay what you guys have been doing in any way, what I mean't was basically that you have other priorities, and that you don't want to prioritise this issue. That's all.
@jeremystretch commented on GitHub (Dec 10, 2021):
I'm still not sure what this issue is supposed to address. If you're seeing webhooks fire for both the update and delete actions when deleting a device, that is to be expected in many cases. For example, if a device has a primary IP address assigned to it, and that IP is deleted immediately prior to the device being deleted (because its assigned interface on the device has been deleted), the device will be updated to nullify its primary IP, and then it will be deleted. If this is the case, there's no action be taken because there's nothing to fix.
If your issue is not what I described above, please elaborate on exactly what the problem is.
@ifoughal commented on GitHub (Dec 15, 2021):
That is the exact scenario, as you have described.
If there's no action to be taken from your side, then you may go ahead with the closure if this issue.
For future users who might be facing the same issue as us, our use case was automating devices addition and removal from the monitoring services automatically, by triggering the webhook.
This has affected the automation process on our side, therefore Netbox as a dynamic inventory can't be fully exploited in this scenario.
@jeremystretch commented on GitHub (Dec 15, 2021):
I don't understand why that would be the case: The webhook clearly indicates what type of action is being taken (update vs. deletion) in each request. You might also look into defining a set of conditions for finer control over when webhooks fire.
At any rate, there doesn't seem to be any action to take here so I'll close this out.