starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

When editing a device interface "Parent" and "LAG" choices are not scoped to current device #5125

New Issue
Closed
opened 2025-12-29 19:24:32 +01:00 by adam · 3 comments
adam commented 2025-12-29 19:24:32 +01:00
Owner
Copy Link

Originally created by @maznu on GitHub (Jul 31, 2021).

NetBox version

v3.0-beta1

Python version

3.7

Steps to Reproduce

  1. Edit a device interface.
  2. Click on the "Parent Interface" or "LAG Interface" drop-down.
  3. Oh no, it's every single device-interface (up to MAX_PAGE_SIZE).

Expected Behavior

Parent should only allow interfaces on the current device.

Observed Behavior

Drop-downs fetch /api/dcim/interfaces/?brief=true&limit=0 and /api/dcim/interfaces/?brief=true&limit=0&type_id=virtual with no filter.

Originally created by @maznu on GitHub (Jul 31, 2021). ### NetBox version v3.0-beta1 ### Python version 3.7 ### Steps to Reproduce 1. Edit a device interface. 2. Click on the "Parent Interface" or "LAG Interface" drop-down. 3. Oh no, it's every single device-interface (up to MAX_PAGE_SIZE). ### Expected Behavior Parent should only allow interfaces on the current device. ### Observed Behavior Drop-downs fetch `/api/dcim/interfaces/?brief=true&limit=0` and `/api/dcim/interfaces/?brief=true&limit=0&type_id=virtual` with no filter.
adam added the type: bugbeta labels 2025-12-29 19:24:32 +01:00
adam closed this issue 2025-12-29 19:24:32 +01:00
adam commented 2025-12-29 19:24:33 +01:00
Author
Owner
Copy Link

@thatmattlove commented on GitHub (Aug 1, 2021):

This was reported in #6797 and should have been fixed in 5413263, see here. Can you pull the latest changes from the feature branch and test again, please?

@thatmattlove commented on GitHub (Aug 1, 2021): This was reported in #6797 and should have been fixed in 5413263, see [here](https://github.com/netbox-community/netbox/issues/6797#issuecomment-889729361). Can you pull the latest changes from the `feature` branch and test again, please?
adam commented 2025-12-29 19:24:33 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Aug 2, 2021):

Can confirm this has already been resolved in feature.

@jeremystretch commented on GitHub (Aug 2, 2021): Can confirm this has already been resolved in `feature`.
adam commented 2025-12-29 19:24:33 +01:00
Author
Owner
Copy Link

@maznu commented on GitHub (Aug 14, 2021):

Tested against beta2:

I think there's sort of still an issue, but it's a bit more subtle now.

If I'm on a high latency link (3G, VPN, etc) then what I notice happening is this:

  1. go to make a cable connection from a device interface to another device interface
  2. drop down the list of devices for the right hand side
  3. select my device
  4. API query returns with a couple of interfaces
  5. …and then the earlier API query which had all the interfaces ever returns, and the interface drop-down is unhelpful

Here's a video to explain better: https://fs.maz.nu/netbox-api-concurrency-dfBBU8lPyNPPbxBC.mov

You'll see "eth0" at the top of the interface list for just a moment, before it looks like the earlier "all interfaces" query returns with everything.

@maznu commented on GitHub (Aug 14, 2021): Tested against beta2: I think there's sort of still an issue, but it's a bit more subtle now. If I'm on a high latency link (3G, VPN, etc) then what I notice happening is this: 1. go to make a cable connection from a device interface to another device interface 2. drop down the list of devices for the right hand side 3. select my device 4. API query returns with a couple of interfaces 5. …and then the earlier API query which had all the interfaces ever returns, and the interface drop-down is unhelpful Here's a video to explain better: https://fs.maz.nu/netbox-api-concurrency-dfBBU8lPyNPPbxBC.mov You'll see "eth0" at the top of the interface list for just a moment, before it looks like the earlier "all interfaces" query returns with everything.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label beta type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#5125
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?