starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Replace FeatureQuery roles with model types #4941

New Issue
Closed
opened 2025-12-29 19:22:28 +01:00 by adam · 2 comments
adam commented 2025-12-29 19:22:28 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (May 21, 2021).

Proposed Changes

Now that extra features (custom fields, webhooks, etc.) have all been standardized across model types, there's no need to track these individually. We should refactor FeatureQuery to register models based on their parent class rather than a static list of features.

Justification

Simplifies the code base and reduces opportunity for error

Originally created by @jeremystretch on GitHub (May 21, 2021). ### Proposed Changes Now that extra features (custom fields, webhooks, etc.) have all been standardized across model types, there's no need to track these individually. We should refactor FeatureQuery to register models based on their parent class rather than a static list of features. ### Justification Simplifies the code base and reduces opportunity for error
adam added the type: housekeeping label 2025-12-29 19:22:28 +01:00
adam closed this issue 2025-12-29 19:22:28 +01:00
adam commented 2025-12-29 19:22:29 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 21, 2021):

I should also note that we still need to preserve the ability to register specific features (for plugins). We can just make inferences based on the stock model classifications.

@jeremystretch commented on GitHub (May 21, 2021): I should also note that we still need to preserve the ability to register specific features (for plugins). We can just make inferences based on the stock model classifications.
adam commented 2025-12-29 19:22:29 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Sep 15, 2021):

Going to close this as there hasn't been any progress nor any real impetus for the change.

@jeremystretch commented on GitHub (Sep 15, 2021): Going to close this as there hasn't been any progress nor any real impetus for the change.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4941
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?