starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-02-26 02:35:12 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Add input validation related to reserved/forbidden characters #4895

New Issue
Closed
opened 2025-12-29 19:21:45 +01:00 by adam · 2 comments
adam commented 2025-12-29 19:21:45 +01:00
Owner
Copy Link

Originally created by @yarnocobussen on GitHub (May 11, 2021).

NetBox version

v2.11.3

Feature type

Change to existing functionality

Proposed functionality

It's currently possible to input reserved/forbidden characters into some fields, which breaks functionality. For example: it's possible to use a double underscore in the name field of a custom field, which has a special meaning in Django. This results in broken queries related to these fields. (See #6375 )

The proposed functionality is to add input validation which prevents the use of these character combinations.

Use case

The data in Netbox will be protected from altered behavior caused by unwanted inputs. Users will experience more consistency when interacting with data stored within Netbox.

Database changes

None that I am aware of

External dependencies

None

Originally created by @yarnocobussen on GitHub (May 11, 2021). ### NetBox version v2.11.3 ### Feature type Change to existing functionality ### Proposed functionality It's currently possible to input reserved/forbidden characters into some fields, which breaks functionality. For example: it's possible to use a double underscore in the name field of a custom field, which has a special meaning in Django. This results in broken queries related to these fields. (See #6375 ) The proposed functionality is to add input validation which prevents the use of these character combinations. ### Use case The data in Netbox will be protected from altered behavior caused by unwanted inputs. Users will experience more consistency when interacting with data stored within Netbox. ### Database changes None that I am aware of ### External dependencies None
adam added the type: featurestatus: revisions needed labels 2025-12-29 19:21:45 +01:00
adam closed this issue 2025-12-29 19:21:45 +01:00
adam commented 2025-12-29 19:21:46 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 11, 2021):

The proposed functionality is to add input validation which prevents the use of these character combinations.

Please revise your issue to indicate the specific changes you are proposing, including the model fields and proposed validation rules.

@jeremystretch commented on GitHub (May 11, 2021): > The proposed functionality is to add input validation which prevents the use of these character combinations. Please revise your issue to indicate the *specific* changes you are proposing, including the model fields and proposed validation rules.
adam commented 2025-12-29 19:21:46 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 25, 2021):

Closing due to inactivity.

@jeremystretch commented on GitHub (May 25, 2021): Closing due to inactivity.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: revisions needed type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4895
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?