starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Interface VLAN Dropdown #4856

New Issue
Closed
opened 2025-12-29 19:21:18 +01:00 by adam · 8 comments
adam commented 2025-12-29 19:21:18 +01:00
Owner
Copy Link

Originally created by @amit177 on GitHub (May 1, 2021).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v2.11.2

Python version

3.8

Steps to Reproduce

  1. Create two VLAN groups, "A" and "B"
  2. Create VLAN 100 and assign it to group A
  3. Create VLAN 200 and assign it to group A
  4. Create VLAN 100 and assign it to group B
  5. Create VLAN 200 and assign it to group B
  6. Create a device and an interface inside it
  7. Edit the interface, change 802.1q mode to Access
  8. View the dropdown

Expected Behavior

The dropdown should contain separating lines between each VLAN group when editing the assigned VLAN on a device's interface, as it did before v2.11

Observed Behavior

All the VLANs are mixed together in the dropdown with no separation between them, even ones with the same name.

Originally created by @amit177 on GitHub (May 1, 2021). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v2.11.2 ### Python version 3.8 ### Steps to Reproduce 1. Create two VLAN groups, "A" and "B" 2. Create VLAN 100 and assign it to group A 3. Create VLAN 200 and assign it to group A 4. Create VLAN 100 and assign it to group B 5. Create VLAN 200 and assign it to group B 6. Create a device and an interface inside it 7. Edit the interface, change 802.1q mode to Access 8. View the dropdown ### Expected Behavior The dropdown should contain separating lines between each VLAN group when editing the assigned VLAN on a device's interface, as it did before v2.11 ### Observed Behavior All the VLANs are mixed together in the dropdown with no separation between them, even ones with the same name.
adam added the type: bugstatus: accepted labels 2025-12-29 19:21:18 +01:00
adam closed this issue 2025-12-29 19:21:18 +01:00
adam commented 2025-12-29 19:21:19 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 3, 2021):

The dropdown should contain separating lines between each VLAN group when editing the assigned VLAN on a device's interface, as it did before v2.11

This behavior was intentionally removed for two reasons:

  1. Arranging VLANs by group requires a full (versus brief) API request, which takes much longer
  2. The UI logic required to accomplish the grouping was quite heavy and difficult to maintain

IIRC the original goal was to enable filtering the VLANs list by group and/or site, but that seems to have fallen by the wayside. This is IMO a preferable approach to the inline grouping, which does nothing to limit the total number of VLANs being returned.

@jeremystretch commented on GitHub (May 3, 2021): > The dropdown should contain separating lines between each VLAN group when editing the assigned VLAN on a device's interface, as it did before v2.11 This behavior was intentionally removed for two reasons: 1. Arranging VLANs by group requires a full (versus brief) API request, which takes much longer 2. The UI logic required to accomplish the grouping was quite heavy and difficult to maintain IIRC the original goal was to enable filtering the VLANs list by group and/or site, but that seems to have fallen by the wayside. This is IMO a preferable approach to the inline grouping, which does nothing to limit the total number of VLANs being returned.
adam commented 2025-12-29 19:21:19 +01:00
Author
Owner
Copy Link

@amit177 commented on GitHub (May 7, 2021):

Filtering by the scope set would work as well.
I'm currently running v2.11.3 and having trouble with identifying what VLAN is from which group when I'm editing an interface.
We have VLANs that have duplicate names but are in different groups.
It makes it a pain to find the correct VLAN now

@amit177 commented on GitHub (May 7, 2021): Filtering by the scope set would work as well. I'm currently running v2.11.3 and having trouble with identifying what VLAN is from which group when I'm editing an interface. We have VLANs that have duplicate names but are in different groups. It makes it a pain to find the correct VLAN now
adam commented 2025-12-29 19:21:19 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Jul 7, 2021):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Jul 7, 2021): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 19:21:19 +01:00
Author
Owner
Copy Link

@ksaegusa commented on GitHub (Jul 16, 2021):

Hello.

I'm facing a similar problem.

For example, If we can change the pull-down display to the following, we can solve the problem

Name (id) (vlan_group_name)

@ksaegusa commented on GitHub (Jul 16, 2021): Hello. I'm facing a similar problem. For example, If we can change the pull-down display to the following, we can solve the problem `Name (id) (vlan_group_name)`
adam commented 2025-12-29 19:21:19 +01:00
Author
Owner
Copy Link

@ziggekatten commented on GitHub (Aug 12, 2021):

The only issue that currently make us stick with 2.10.x. is this one.

@ziggekatten commented on GitHub (Aug 12, 2021): The only issue that currently make us stick with 2.10.x. is this one.
adam commented 2025-12-29 19:21:19 +01:00
Author
Owner
Copy Link

@ziggekatten commented on GitHub (Aug 17, 2021):

Jeremy, will this issue be fixed in version 3.x?

@ziggekatten commented on GitHub (Aug 17, 2021): Jeremy, will this issue be fixed in version 3.x?
adam commented 2025-12-29 19:21:19 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Aug 17, 2021):

You're welcome to try out the the public demo and check for yourself. So far, it doesn't look like anyone is interested in volunteering to take on the work, unfortunately.

@jeremystretch commented on GitHub (Aug 17, 2021): You're welcome to try out the the [public demo](https://beta-demo.netbox.dev/) and check for yourself. So far, it doesn't look like anyone is interested in volunteering to take on the work, unfortunately.
adam commented 2025-12-29 19:21:20 +01:00
Author
Owner
Copy Link

@amit177 commented on GitHub (Aug 28, 2021):

@jeremystretch great fix, thank you!

@amit177 commented on GitHub (Aug 28, 2021): @jeremystretch great fix, thank you!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4856
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?