starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Connect Form | filter devices which have the chosen Connector Type #4728

New Issue
Closed
opened 2025-12-29 19:19:55 +01:00 by adam · 9 comments
adam commented 2025-12-29 19:19:55 +01:00
Owner
Copy Link

Originally created by @teixemf on GitHub (Apr 7, 2021).

NetBox version

v2.11 beta

Feature type

Change to existing functionality

Proposed functionality

While trying to connect an Interface/Front Port/Rear Port/Circuit Termination to a device, on the Connect Form, the list of devices available to be chosen should be limited to the devices which have the chosen Connector Type.
Same for Power Outlet/Power Feed.

Use case

If for instance, I choose to connect a Switch interface to a Front Port it would be expected to be able to chose from a list of devices which have Front Ports (like patch-panels) and not all the devices available on the rack.
On racks with many devices this could really help to narrow down the devices list.

Database changes

No DB changes.

External dependencies

No dependencies.

Originally created by @teixemf on GitHub (Apr 7, 2021). ### NetBox version v2.11 beta ### Feature type Change to existing functionality ### Proposed functionality While trying to connect an Interface/Front Port/Rear Port/Circuit Termination to a device, on the Connect Form, the list of devices available to be chosen should be limited to the devices which have the chosen Connector Type. Same for Power Outlet/Power Feed. ### Use case If for instance, I choose to connect a Switch interface to a Front Port it would be expected to be able to chose from a list of devices which have Front Ports (like patch-panels) and not all the devices available on the rack. On racks with many devices this could really help to narrow down the devices list. ### Database changes No DB changes. ### External dependencies No dependencies.
adam added the type: featurestatus: needs ownerpending closure labels 2025-12-29 19:19:55 +01:00
adam closed this issue 2025-12-29 19:19:55 +01:00
adam commented 2025-12-29 19:19:56 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 7, 2021):

I think the idea makes sense in principle, however I worry about the potential it introduces for confusion. For example, suppose a device mistakenly has its console port deleted. When a user goes to connect a cable to a console port and looks for the device, it won't be listed, and it won't be immediately apparent to the user why the device has been omitted.

@jeremystretch commented on GitHub (Apr 7, 2021): I think the idea makes sense in principle, however I worry about the potential it introduces for confusion. For example, suppose a device mistakenly has its console port deleted. When a user goes to connect a cable to a console port and looks for the device, it won't be listed, and it won't be immediately apparent to the user why the device has been omitted.
adam commented 2025-12-29 19:19:56 +01:00
Author
Owner
Copy Link

@phurrelmann commented on GitHub (Apr 8, 2021):

I see you point Jeremy, but the current situation is more prone to errors. It happens quite often that one inadvertently selects "interface" instead of rear or front ports and only realizes that mistake when the connections dialog errors out late due to mismatching types and makes you re-enter all cable details again. Especially with rear and front ports this gets more attraction. In general there are probably more devices with interfaces in a rack than devices with front and rear ports. Working with front and rear ports always shows all devices in the corresponding dropdowns.
This on my wish list for a long time, but I admit that this is not a blocking issue. It just may improve usability besides sacrificing the edge case you described.

@phurrelmann commented on GitHub (Apr 8, 2021): I see you point Jeremy, but the current situation is more prone to errors. It happens quite often that one inadvertently selects "interface" instead of rear or front ports and only realizes that mistake when the connections dialog errors out late due to mismatching types and makes you re-enter all cable details again. Especially with rear and front ports this gets more attraction. In general there are probably more devices with interfaces in a rack than devices with front and rear ports. Working with front and rear ports always shows all devices in the corresponding dropdowns. This on my wish list for a long time, but I admit that this is not a blocking issue. It just may improve usability besides sacrificing the edge case you described.
adam commented 2025-12-29 19:19:56 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 9, 2021):

Let me put it this way. Suppose we implement your proposed change, and the next week we get a new bug report:

I was trying to connect a cable to a particular device, but it wasn't showing up in the list. A bunch of other device were, but this one was missing. I thought maybe it was a caching problem so I cleared out the cache, but it didn't help. I double-checked that the device definitely exists and is assigned to the correct site and rack. It was only after 15 minutes of troubleshooting that I realized the device's console port had gotten deleted at some point! Once I added the console port, the device appeared in the list. Please fix NetBox to show all devices when attempting to connect a cable so we can avoid future headaches!

Sounds very reasonable to me.

@jeremystretch commented on GitHub (Apr 9, 2021): Let me put it this way. Suppose we implement your proposed change, and the next week we get a new bug report: > I was trying to connect a cable to a particular device, but it wasn't showing up in the list. A bunch of other device were, but this one was missing. I thought maybe it was a caching problem so I cleared out the cache, but it didn't help. I double-checked that the device definitely exists and is assigned to the correct site and rack. It was only after 15 minutes of troubleshooting that I realized the device's console port had gotten deleted at some point! Once I added the console port, the device appeared in the list. Please fix NetBox to show _all_ devices when attempting to connect a cable so we can avoid future headaches! Sounds very reasonable to me.
adam commented 2025-12-29 19:19:56 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 4, 2021):

Discussed this with the other maintainers today. Another option proposed by @checktheroads was to include inapplicable devices but mark them as disabled in the dropdown list. I like this approach, however we should consider the additional performance penalty being imposed (to check for the appropriate type of component assigned to each device in the list).

We would be able to work around the performance penalty by caching e.g. _console_port_count on the Device model. This would also come in handy for the UI, where we display a count of each component type assigned to a device.

@jeremystretch commented on GitHub (May 4, 2021): Discussed this with the other maintainers today. Another option proposed by @checktheroads was to include inapplicable devices but mark them as disabled in the dropdown list. I like this approach, however we should consider the additional performance penalty being imposed (to check for the appropriate type of component assigned to each device in the list). We would be able to work around the performance penalty by caching e.g. `_console_port_count` on the Device model. This would also come in handy for the UI, where we display a count of each component type assigned to a device.
adam commented 2025-12-29 19:19:57 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 4, 2021):

I've opened #6347 for component count caching; marking this as blocked for now.

@jeremystretch commented on GitHub (May 4, 2021): I've opened #6347 for component count caching; marking this as blocked for now.
adam commented 2025-12-29 19:19:57 +01:00
Author
Owner
Copy Link

@sdktr commented on GitHub (Jun 2, 2021):

On our custom frontend we show the inapplicable items as well. We however try to explain WHY an item is unselectable, which greatly helps in the user experience.

Eg: 'Another Circuit is already connected' is shown when hovering the greyed out option. (We use a modal, not a dropdown)

@sdktr commented on GitHub (Jun 2, 2021): On our custom frontend we show the inapplicable items as well. We however try to explain WHY an item is unselectable, which greatly helps in the user experience. Eg: 'Another Circuit is already connected' is shown when hovering the greyed out option. (We use a modal, not a dropdown)
adam commented 2025-12-29 19:19:57 +01:00
Author
Owner
Copy Link

@llamafilm commented on GitHub (Jan 2, 2024):

I would also like to see this feature implemented. It would make it much easier to find the device you’re looking for, especially for power outlets, which most devices don’t have.

Jeremy’s counter-example sounds like an edge case, accidentally deleting ports from a device.

@llamafilm commented on GitHub (Jan 2, 2024): I would also like to see this feature implemented. It would make it much easier to find the device you’re looking for, especially for power outlets, which most devices don’t have. Jeremy’s counter-example sounds like an edge case, accidentally deleting ports from a device.
adam commented 2025-12-29 19:19:57 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Apr 2, 2024):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Apr 2, 2024): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/develop/CONTRIBUTING.md).
adam commented 2025-12-29 19:19:57 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (May 3, 2024):

This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.

@github-actions[bot] commented on GitHub (May 3, 2024): This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pending closure status: needs owner type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4728
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?