starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

'auth > group' and 'auth > user' Permissions Not Taking Effect #4706

New Issue
Closed
opened 2025-12-29 19:19:40 +01:00 by adam · 5 comments
adam commented 2025-12-29 19:19:40 +01:00
Owner
Copy Link

Originally created by @coda88 on GitHub (Mar 27, 2021).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v2.10.8

Python version

3.6

Steps to Reproduce

  1. Create a new user 'user01' with 'Active' and 'Staff status' (no 'Superuser status')
  2. Create a new permission with 'Can view' action and the following Chosen object types: 'auth > group', 'auth > user', 'users > permission' and 'users > token'
  3. Assign the new permission to 'user01'

Expected Behavior

  1. Log in as 'user01'
  2. Navigate to <netbox_url>/admin
  3. 'user01' should see 'Groups', 'Permissions', 'Tokens' and 'Users' under the 'USERS' section on the left menu.

Observed Behavior

  1. 'user01' is not able to see 'Groups' and 'Users' under the 'USERS' section on the left menu.
  2. 'user01' is only able to see 'Permissions' and 'Tokens' under the 'USERS' section on the left menu.
Originally created by @coda88 on GitHub (Mar 27, 2021). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v2.10.8 ### Python version 3.6 ### Steps to Reproduce 1. Create a new user 'user01' with 'Active' and 'Staff status' (no 'Superuser status') 2. Create a new permission with 'Can view' action and the following Chosen object types: 'auth > group', 'auth > user', 'users > permission' and 'users > token' 3. Assign the new permission to 'user01' ### Expected Behavior 1. Log in as 'user01' 2. Navigate to <netbox_url>/admin 3. 'user01' should see 'Groups', 'Permissions', 'Tokens' and 'Users' under the 'USERS' section on the left menu. ### Observed Behavior 1. 'user01' is not able to see 'Groups' and 'Users' under the 'USERS' section on the left menu. 2. 'user01' is only able to see 'Permissions' and 'Tokens' under the 'USERS' section on the left menu.
adam added the type: bugstatus: accepted labels 2025-12-29 19:19:40 +01:00
adam closed this issue 2025-12-29 19:19:41 +01:00
adam commented 2025-12-29 19:19:41 +01:00
Author
Owner
Copy Link

@coda88 commented on GitHub (Mar 27, 2021):

After going through the API, it seems that the correct object types for 'Groups' and 'Users' are 'users > Group' and 'users > User' respectively instead. But these object types are not exposed in the Web GUI.

Tested by modifying users/model.py, after which, 'users > Group' and 'users > User' appears in the GUI under 'Available object types':

$ diff netbox/users/models.py netbox/users/models.py.original
256c256
<             Q(app_label='users', model__in=['admingroup', 'adminuser', 'objectpermission', 'token'])
---
>             Q(app_label='users', model__in=['objectpermission', 'token'])
@coda88 commented on GitHub (Mar 27, 2021): After going through the API, it seems that the correct object types for 'Groups' and 'Users' are 'users > Group' and 'users > User' respectively instead. But these object types are not exposed in the Web GUI. Tested by modifying users/model.py, after which, 'users > Group' and 'users > User' appears in the GUI under 'Available object types': ``` $ diff netbox/users/models.py netbox/users/models.py.original 256c256 < Q(app_label='users', model__in=['admingroup', 'adminuser', 'objectpermission', 'token']) --- > Q(app_label='users', model__in=['objectpermission', 'token']) ```
adam commented 2025-12-29 19:19:41 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Mar 31, 2021):

The discrepancy is due to the use of the abstract AdminUser and AdminGroup classes within the admin UI. IIRC these are employed primarily so that the user and group items appear under the "Users" section of the admin UI. There are probably a couple ways to go about tweaking this; I'll need to dig into it some more.

@jeremystretch commented on GitHub (Mar 31, 2021): The discrepancy is due to the use of the abstract AdminUser and AdminGroup classes within the admin UI. IIRC these are employed primarily so that the user and group items appear under the "Users" section of the admin UI. There are probably a couple ways to go about tweaking this; I'll need to dig into it some more.
adam commented 2025-12-29 19:19:42 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Apr 15, 2021):

We can fix this by simply getting rid of the abstract AdminUser and AdminGroup classes, although these models will end up back under "Authorization and Authentication" (rather than "Users") in Django the admin UI, which is a bit confusing. Would love to come up with an elegant solution but haven't had any luck thus far.

@jeremystretch commented on GitHub (Apr 15, 2021): We can fix this by simply getting rid of the abstract AdminUser and AdminGroup classes, although these models will end up back under "Authorization and Authentication" (rather than "Users") in Django the admin UI, which is a bit confusing. Would love to come up with an elegant solution but haven't had any luck thus far.
adam commented 2025-12-29 19:19:42 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 18, 2021):

IMO we should go ahead with ditching the abstract models to fix the bug in the immediate term. Long term, we'll likely move away from Django's admin UI anyway (in favor of our own custom views).

@jeremystretch commented on GitHub (May 18, 2021): IMO we should go ahead with ditching the abstract models to fix the bug in the immediate term. Long term, we'll likely move away from Django's admin UI anyway (in favor of our own custom views).
adam commented 2025-12-29 19:19:42 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (May 28, 2021):

Long term, we'll likely move away from Django's admin UI anyway (in favor of our own custom views).

Just following up on this: see #6466.

@jeremystretch commented on GitHub (May 28, 2021): > Long term, we'll likely move away from Django's admin UI anyway (in favor of our own custom views). Just following up on this: see #6466.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4706
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?