starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Drop backward compatibility for specifying queryset on custom script ObjectVar, MultiObjectVar #4671

New Issue
Closed
opened 2025-12-29 19:19:20 +01:00 by adam · 0 comments
adam commented 2025-12-29 19:19:20 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Mar 16, 2021).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Drop backward compatibility for the queryset keyword argument for custom script ObjectVar and MultiObjectVar field types. These fields should be initialized using the model keyword instead. For example,

device1 = ObjectVar(
    queryset=Device.objects.all()
)

becomes:

device1 = ObjectVar(
    model=Device
)

Justification

NetBox currently issues a warning when initializing these fields with queryset, and its use is deprecated. The model parameter was introduced to eliminate confusion regarding filter of available options (which should be done using the query_params parameter).

Originally created by @jeremystretch on GitHub (Mar 16, 2021). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Drop backward compatibility for the `queryset` keyword argument for custom script ObjectVar and MultiObjectVar field types. These fields should be initialized using the `model` keyword instead. For example, ``` device1 = ObjectVar( queryset=Device.objects.all() ) ``` becomes: ``` device1 = ObjectVar( model=Device ) ``` ### Justification NetBox currently issues a warning when initializing these fields with `queryset`, and its use is deprecated. The `model` parameter was introduced to eliminate confusion regarding filter of available options (which should be done using the `query_params` parameter).
adam added the status: acceptedtype: deprecation labels 2025-12-29 19:19:20 +01:00
adam closed this issue 2025-12-29 19:19:20 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: deprecation
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4671
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?