Template tags do not take into account plugins #4637

New Issue

adam · 2025-12-29T19:18:55+01:00

adam commented

2025-12-29 19:18:55 +01:00

Originally created by @DanSheps on GitHub (Mar 8, 2021).

Originally assigned to: @DanSheps on GitHub.

Proposed Changes

Wrap reverse() in try/catch statement to test against both plugins and base namespace.

Justification

Currently, these button tags do not test against the plugins namespace. This would add testing against the namespace with and preserve the original.

Sample code:

    try:
        url = reverse(viewname, kwargs={'pk': instance.pk})
    except NoReverseMatch as e:
        try:
            url = reverse(f'plugins:{viewname}', kwargs={'pk': instance.pk})
        except NoReverseMatch:
            raise NoReverseMatch(e)

Originally created by @DanSheps on GitHub (Mar 8, 2021). Originally assigned to: @DanSheps on GitHub. ### Proposed Changes Wrap reverse() in try/catch statement to test against both plugins and base namespace. ### Justification Currently, these button tags do not test against the plugins namespace. This would add testing against the namespace with and preserve the original. Sample code: ``` try: url = reverse(viewname, kwargs={'pk': instance.pk}) except NoReverseMatch as e: try: url = reverse(f'plugins:{viewname}', kwargs={'pk': instance.pk}) except NoReverseMatch: raise NoReverseMatch(e) ```

adam added the status: under review type: housekeeping labels 2025-12-29 19:18:56 +01:00

adam closed this issue

2025-12-29 19:18:56 +01:00

adam commented

2025-12-29 19:18:56 +01:00

@jeremystretch commented on GitHub (Mar 11, 2021):

I don't follow. Can you point to an example where this is breaking something in NetBox? IMO it's bad practice to try and "brute force" the URL resolution: The tag should know when it's being called what URL it intends to resolve.

@jeremystretch commented on GitHub (Mar 11, 2021): I don't follow. Can you point to an example where this is breaking something in NetBox? IMO it's bad practice to try and "brute force" the URL resolution: The tag should know when it's being called what URL it intends to resolve.

adam commented

2025-12-29 19:18:56 +01:00

@DanSheps commented on GitHub (Mar 11, 2021):

An example would be ButtonColumn where you resolve the URL automatically for edit/delete/changelog, the button does not take into account the fact that a URL might be in a sub-namespace (plugins:xxx for example) as the resolution is simply f'{model._meta.app_label}:{model._meta.model_name}_{action}'

The try: except: is not the final version now, it has been changed slightly to be a little more sane.

@DanSheps commented on GitHub (Mar 11, 2021): An example would be ButtonColumn where you resolve the URL automatically for edit/delete/changelog, the button does not take into account the fact that a URL might be in a sub-namespace (plugins:xxx for example) as the resolution is simply `f'{model._meta.app_label}:{model._meta.model_name}_{action}'` The try: except: is not the final version now, it has been changed slightly to be a little more sane.

adam commented

2025-12-29 19:18:59 +01:00

@jeremystretch commented on GitHub (Mar 17, 2021):

These tags aren't intended for use within plugins, so we don't check the plugins space. Supporting the use of these internal components within a plugin is a much greater undertaking, involving formally extending the plugins API and documenting their usage.

@jeremystretch commented on GitHub (Mar 17, 2021): These tags aren't intended for use within plugins, so we don't check the plugins space. Supporting the use of these internal components within a plugin is a much greater undertaking, involving formally extending the plugins API and documenting their usage.

adam referenced this issue

2025-12-29 22:24:13 +01:00

[PR #4637] [MERGED] #4634 - Correct inventory item table accessor definition on manufacturer column #12892

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#4637