starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Rename RackGroup to Location #4608

New Issue
Closed
opened 2025-12-29 18:38:12 +01:00 by adam · 2 comments
adam commented 2025-12-29 18:38:12 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Feb 27, 2021).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Rename the RackGroup model to Location (or some similarly generic term). This is a fairly substantial change, as it would entail renaming the model, database table, URLs, and REST API endpoints and serializers. We would also rename the rack_group field on the Rack model and add a location field to Device.

Justification

This change would be prudent to accommodate #4971, which seeks to support the direct assignment of devices to rack groups, in a scenario where rack groups are used primarily to subdivide a parent site (e.g. into rooms or floors) rather than to group racks.

Originally created by @jeremystretch on GitHub (Feb 27, 2021). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Rename the RackGroup model to Location (or some similarly generic term). This is a fairly substantial change, as it would entail renaming the model, database table, URLs, and REST API endpoints and serializers. We would also rename the `rack_group` field on the Rack model and add a `location` field to Device. ### Justification This change would be prudent to accommodate #4971, which seeks to support the direct assignment of devices to rack groups, in a scenario where rack groups are used primarily to subdivide a parent site (e.g. into rooms or floors) rather than to group racks.
adam added the status: acceptedtype: housekeeping labels 2025-12-29 18:38:12 +01:00
adam closed this issue 2025-12-29 18:38:12 +01:00
adam commented 2025-12-29 18:38:12 +01:00
Author
Owner
Copy Link

@ryanmerolle commented on GitHub (Feb 27, 2021):

People are already using RackGroups as such, so it seems only prudent to rename.

@ryanmerolle commented on GitHub (Feb 27, 2021): People are already using RackGroups as such, so it seems only prudent to rename.
adam commented 2025-12-29 18:38:12 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 27, 2021):

My only concern is that this could be a fairly disruptive change. It probably makes sense to retain the current related fields as read-only aliases of the new fields to support backward compatibility for all v2.11 releases. We could even go so far as replicating the API endpoints (to provide both /dcim/rack-groups/ and /dcim/locations/), though I'm not sure how complicated that becomes.

@jeremystretch commented on GitHub (Feb 27, 2021): My only concern is that this could be a fairly disruptive change. It probably makes sense to retain the current related fields as read-only aliases of the new fields to support backward compatibility for all v2.11 releases. We could even go so far as replicating the API endpoints (to provide both `/dcim/rack-groups/` and `/dcim/locations/`), though I'm not sure how complicated that becomes.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4608
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?