Extend upgrade.sh to automatically upgrade pip #4548

New Issue

adam · 2025-12-29T18:37:20+01:00

adam commented

2025-12-29 18:37:20 +01:00

Originally created by @jeremystretch on GitHub (Feb 9, 2021).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Add a step in upgrade.sh to upgrade the Python package manager (pip). E.g. pip install --upgrade pip.

Justification

When the virtual environment is created, a copy of the system pip is used. If this is out of date, it can lead to installation problems such as the one documented in #5774.

Originally created by @jeremystretch on GitHub (Feb 9, 2021). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Add a step in `upgrade.sh` to upgrade the Python package manager (pip). E.g. `pip install --upgrade pip`. ### Justification When the virtual environment is created, a copy of the system pip is used. If this is out of date, it can lead to installation problems such as the one documented in #5774.

adam added the status: accepted type: housekeeping labels 2025-12-29 18:37:20 +01:00

adam closed this issue

2025-12-29 18:37:21 +01:00

adam commented

2025-12-29 18:37:21 +01:00

@candlerb commented on GitHub (Feb 12, 2021):

Based on report #5813 (problems with opensuse), I found a further modification is required:

--- upgrade.sh.orig	2021-02-12 14:56:01.992398949 +0000
+++ upgrade.sh	2021-02-12 14:56:49.396667022 +0000
@@ -30,16 +30,11 @@
 source "${VIRTUALENV}/bin/activate"

 # Upgrade pip
-COMMAND="pip install --upgrade pip"
+COMMAND="pip install --upgrade pip setuptools wheel"
 echo "Updating pip ($COMMAND)..."
 eval $COMMAND || exit 1
 pip -V

-# Install necessary system packages
-COMMAND="pip install wheel"
-echo "Installing Python system packages ($COMMAND)..."
-eval $COMMAND || exit 1
-
 # Install required Python packages
 COMMAND="pip install -r requirements.txt"
 echo "Installing core dependencies ($COMMAND)..."

That's from following the instructions here, and works in my test environment.

@candlerb commented on GitHub (Feb 12, 2021): Based on report #5813 (problems with opensuse), I found a further modification is required: ``` --- upgrade.sh.orig 2021-02-12 14:56:01.992398949 +0000 +++ upgrade.sh 2021-02-12 14:56:49.396667022 +0000 @@ -30,16 +30,11 @@ source "${VIRTUALENV}/bin/activate" # Upgrade pip -COMMAND="pip install --upgrade pip" +COMMAND="pip install --upgrade pip setuptools wheel" echo "Updating pip ($COMMAND)..." eval $COMMAND || exit 1 pip -V -# Install necessary system packages -COMMAND="pip install wheel" -echo "Installing Python system packages ($COMMAND)..." -eval $COMMAND || exit 1 - # Install required Python packages COMMAND="pip install -r requirements.txt" echo "Installing core dependencies ($COMMAND)..." ``` That's from following the instructions [here](https://python-packaging-user-guide.readthedocs.io/tutorials/installing-packages/#ensure-pip-setuptools-and-wheel-are-up-to-date), and works in my test environment.

adam referenced this issue

2025-12-29 19:30:17 +01:00

Trace Splits 1:1 connections using front-port to front-port jump on same patch panel #5629

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#4548