starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Flag for Review System #4542

New Issue
Closed
opened 2025-12-29 18:37:06 +01:00 by adam · 3 comments
adam commented 2025-12-29 18:37:06 +01:00
Owner
Copy Link

Originally created by @stuntguy3000 on GitHub (Feb 9, 2021).

Environment

  • Python version: 3.6.8
  • NetBox version: 2.10.4

Proposed Functionality

A function to flag objects for review with/without comments, to then be reviewed by users from an automatically generated "to-do" list.

An expansion on this could be adding in scheduled review dates, for example documentation may need to be verified as correct every x months.

Use Case

  1. Engineers reviewing the documentation may notice mistakes or question certain elements which they believe to be wrong. These mistakes could be flagged for review and checked over in bulk.

  2. After a critical ICT incident, infrastructure may change in more uncontrolled ways. Devices/objects could be flagged for review during or shortly after critical incidents to be followed up on.

Database Changes

Unknown, but likely.

External Dependencies

Unknown, but not likely.

Originally created by @stuntguy3000 on GitHub (Feb 9, 2021). <!-- NOTE: IF YOUR ISSUE DOES NOT FOLLOW THIS TEMPLATE, IT WILL BE CLOSED. This form is only for proposing specific new features or enhancements. If you have a general idea or question, please start a discussion instead: https://github.com/netbox-community/netbox/discussions NOTE: Due to an excessive backlog of feature requests, we are not currently accepting any proposals which significantly extend NetBox's feature scope. Please describe the environment in which you are running NetBox. Be sure that you are running an unmodified instance of the latest stable release before submitting a bug report. --> ### Environment * Python version: 3.6.8 * NetBox version: 2.10.4 <!-- Describe in detail the new functionality you are proposing. Include any specific changes to work flows, data models, or the user interface. --> ### Proposed Functionality A function to flag objects for review with/without comments, to then be reviewed by users from an automatically generated "to-do" list. An expansion on this could be adding in scheduled review dates, for example documentation may need to be verified as correct every x months. <!-- Convey an example use case for your proposed feature. Write from the perspective of a NetBox user who would benefit from the proposed functionality and describe how. ---> ### Use Case 1) Engineers reviewing the documentation may notice mistakes or question certain elements which they believe to be wrong. These mistakes could be flagged for review and checked over in bulk. 2) After a critical ICT incident, infrastructure may change in more uncontrolled ways. Devices/objects could be flagged for review during or shortly after critical incidents to be followed up on. <!-- Note any changes to the database schema necessary to support the new feature. For example, does the proposal require adding a new model or field? (Not all new features require database changes.) ---> ### Database Changes Unknown, but likely. <!-- List any new dependencies on external libraries or services that this new feature would introduce. For example, does the proposal require the installation of a new Python package? (Not all new features introduce new dependencies.) --> ### External Dependencies Unknown, but not likely.
adam added the plugin candidate label 2025-12-29 18:37:06 +01:00
adam closed this issue 2025-12-29 18:37:06 +01:00
adam commented 2025-12-29 18:37:07 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 9, 2021):

It sounds like you have a very specific workflow you'd like to implement. This is likely highly unique to your own organization and not something that would be reasonable to implement in the NetBox core. However, you might consider writing a plugin to implement the functionality you seek.

@jeremystretch commented on GitHub (Feb 9, 2021): It sounds like you have a very specific workflow you'd like to implement. This is likely highly unique to your own organization and not something that would be reasonable to implement in the NetBox core. However, you might consider [writing a plugin](https://netbox.readthedocs.io/en/stable/plugins/development/) to implement the functionality you seek.
adam commented 2025-12-29 18:37:07 +01:00
Author
Owner
Copy Link

@stuntguy3000 commented on GitHub (Feb 9, 2021):

The feature doesn't sound very specific at all, it comes down to being able to flag mistakes within a documentation system. That doesn't sound very specific...

Surely many people would find that useful since it can be used in many ways.

@stuntguy3000 commented on GitHub (Feb 9, 2021): The feature doesn't sound very specific at all, it comes down to being able to flag mistakes within a documentation system. That doesn't sound very specific... Surely many people would find that useful since it can be used in many ways.
adam commented 2025-12-29 18:37:07 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 9, 2021):

All the more reason to write a plugin, then.

@jeremystretch commented on GitHub (Feb 9, 2021): All the more reason to write a plugin, then.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label plugin candidate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#4542
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?